> On April 28, 2016, 5:02 p.m., Kirk Lund wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/MBeanServerWrapper.java,
> >  line 244
> > <https://reviews.apache.org/r/46705/diff/1/?file=1362009#file1362009line244>
> >
> >     Should this include e as a cause?
> >     
> >     throw new GemFireSecurityException("...", e);
> >     
> >     It'll be hard to debug if we don't use causes everywhere that we 
> > rethrow.

fixed


- Jinmei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46705/#review130938
-----------------------------------------------------------


On April 26, 2016, 4:20 p.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46705/
> -----------------------------------------------------------
> 
> (Updated April 26, 2016, 4:20 p.m.)
> 
> 
> Review request for geode.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> integration security for JMX and commands
> *shiro security
> *Clean up resource and operation code for permission checking
> 
> 
> Diffs
> -----
> 
>   geode-assembly/build.gradle e849b51 
>   
> geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java
>  b394063 
>   
> geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java
>  e1093a2 
>   geode-assembly/src/test/resources/expected_jars.txt 159d1e6 
>   geode-core/build.gradle 2206018 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/OperationContext.java
>  9482d6b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/AbstractDistributionConfig.java
>  c742005 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ConfigAttribute.java
>  51712f9 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ConfigAttributeChecker.java
>  14c1e54 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ConfigAttributeDesc.java
>  57a4a72 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ConfigAttributeGetter.java
>  678ecf0 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ConfigAttributeSetter.java
>  ad8ad65 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfig.java
>  c1a96ea 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfigImpl.java
>  2f0e1d9 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/AbstractConfig.java 
> 09fc61c 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/security/AuthorizeRequest.java
>  8e550d4 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/AsyncEventQueueMXBean.java
>  e96d78c 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/CacheServerMXBean.java
>  8255a93 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/DiskStoreMXBean.java 
> 79ff056 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/DistributedLockServiceMXBean.java
>  317ee33 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/DistributedRegionMXBean.java
>  3003827 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/DistributedSystemMXBean.java
>  a6f65d4 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/GatewayReceiverMXBean.java
>  519db6c 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/GatewaySenderMXBean.java
>  33c47a4 
>   geode-core/src/main/java/com/gemstone/gemfire/management/LocatorMXBean.java 
> ec4dd88 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/LockServiceMXBean.java
>  85a8e75 
>   geode-core/src/main/java/com/gemstone/gemfire/management/ManagerMXBean.java 
> 7272c8c 
>   geode-core/src/main/java/com/gemstone/gemfire/management/MemberMXBean.java 
> ed27569 
>   geode-core/src/main/java/com/gemstone/gemfire/management/RegionMXBean.java 
> 8c11d00 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/ManagementAgent.java
>  2547070 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/SystemManagementService.java
>  1de666c 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/beans/GatewaySenderMBean.java
>  4b226f4 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/beans/MemberMBeanBridge.java
>  1425572 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/CommandManager.java
>  42539db 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ClientCommands.java
>  a330add 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommands.java
>  a53790c 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java
>  ad006b7 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/DataCommands.java
>  94d5810 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommands.java
>  51663df 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommands.java
>  19fea2d 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/DurableClientCommands.java
>  9e07829 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ExportImportSharedConfigurationCommands.java
>  88308a6 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/FunctionCommands.java
>  9ea5a4c 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/GfshHelpCommands.java
>  9fcc132 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommands.java
>  b3c67bf 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java
>  d73c865 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/MemberCommands.java
>  2c73581 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommands.java
>  b3a183b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/PDXCommands.java
>  820518b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/QueueCommands.java
>  3e67f65 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/RegionCommands.java
>  4e89564 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommands.java
>  951a4b6 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/StatusCommands.java
>  3f4e821 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/WanCommands.java
>  5630885 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/remote/CommandProcessor.java
>  a8d1839 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/result/ErrorResultData.java
>  f8db1d3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/result/ResultBuilder.java
>  16d3f70 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/JmxOperationInvoker.java
>  faf8c52 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/AccessControl.java
>  0331767 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/AccessControlContext.java
>  225d766 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/AccessControlMBean.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/AccessControlMXBean.java
>  68c3d64 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/CLIOperationContext.java
>  4007d09 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/JMXOperationContext.java
>  225555f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/JSONAuthorization.java
>  ef98575 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/MBeanServerWrapper.java
>  d85920c 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/ManagementInterceptor.java
>  c4e7dc5 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/Resource.java
>  5a47c07 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/ResourceConstants.java
>  3a8bbbf 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/ResourceOperation.java
>  ceebd6f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/ResourceOperationContext.java
>  50b22a3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/AbstractCommandsController.java
>  3915e0c 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/ConfigCommandsController.java
>  cd53c51 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/DataCommandsController.java
>  9a27d6b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/DiskStoreCommandsController.java
>  7b99228 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/FunctionCommandsController.java
>  6aff672 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/MiscellaneousCommandsController.java
>  3e8a4f0 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/WanCommandsController.java
>  486b5e3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/support/EnvironmentVariablesHandlerInterceptor.java
>  80773a5 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/http/support/SimpleHttpRequester.java
>  3e110c9 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/shell/AbstractHttpOperationInvoker.java
>  7625354 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/shell/RestHttpOperationInvoker.java
>  5951010 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/shell/SimpleHttpOperationInvoker.java
>  7dc8c3b 
>   geode-core/src/main/java/com/gemstone/gemfire/security/AccessControl.java 
> 92e6258 
>   geode-core/src/main/java/com/gemstone/gemfire/security/Authenticator.java 
> d3fa05b 
>   geode-core/src/main/java/com/gemstone/gemfire/security/CustomAuthRealm.java 
> PRE-CREATION 
>   
> geode-core/src/main/java/com/gemstone/gemfire/security/JMXShiroAuthenticator.java
>  PRE-CREATION 
>   geode-core/src/main/java/com/gemstone/gemfire/security/ShiroUtil.java 
> PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/DistributionConfigJUnitTest.java
>  d2b5643 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/ConfigSourceJUnitTest.java
>  73cd9a0 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/extension/mock/MockExtensionCommands.java
>  4a08ebc 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/CommandManagerJUnitTest.java
>  aac9528 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/GfshParserJUnitTest.java
>  91dd853 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/HeadlessGfsh.java
>  2835731 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java
>  acb07ca 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java
>  9844d90 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java
>  92ed262 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommandsDUnitTest.java
>  fee3978 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java
>  7a9186d 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsJUnitTest.java
>  788e9eb 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/FunctionCommandsDUnitTest.java
>  b4d4df1 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java
>  6858f78 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GetCommandOnRegionWithCacheLoaderDuringCacheMissDUnitTest.java
>  19a354e 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java
>  12c5249 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeDiskStoreCommandsDUnitTest.java
>  6466033 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java
>  ff84036 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListIndexCommandDUnitTest.java
>  deb8860 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java
>  848c1ba 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart1DUnitTest.java
>  60c5ded 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart2DUnitTest.java
>  fbe156a 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart3DUnitTest.java
>  626dbe1 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart4DUnitTest.java
>  cf19659 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/QueueCommandsDUnitTest.java
>  f61ff57 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java
>  d3e004b 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommandsDUnitTest.java
>  86f6dc8 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShowMetricsDUnitTest.java
>  c17f7e7 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShowStackTraceDUnitTest.java
>  6a14a40 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/UserCommandsDUnitTest.java
>  3b4db25 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/shell/GfshExecutionStrategyJUnitTest.java
>  d4edfeb 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/shell/GfshHistoryJUnitTest.java
>  5a5501d 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/AccessControlMBeanJUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/AuthorizeOperationForDistributedSystemMXBeanIntegrationTest.java
>  4ae0107 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/AuthorizeOperationForMBeansIntegrationTest.java
>  d63947b 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/AuthorizeOperationForRegionCommandsIntegrationTest.java
>  ecc4c72 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/CacheServerMBeanAuthenticationJUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/CacheServerMBeanAuthorizationJUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/CacheServerMBeanShiroJUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/CliCommandsSecurityTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/DataCommandsSecurityTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GatewayReceiverMBeanSecurityTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GatewaySenderMBeanSecurityTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GfshCommandsSecurityTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GfshShellConnectionRule.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JMXConnectionConfiguration.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthorization.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthorizationDetailsIntegrationTest.java
>  877f34e 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JsonAuthorizationCacheStartRule.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/LockServiceMBeanAuthorizationJUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/MBeanSecurityJUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/MBeanServerConnectionRule.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ManagerMBeanAuthorizationJUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/MemberMBeanSecurityJUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/OperationCodesForDataCommandsIntegrationTest.java
>  b8c1c9d 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/OperationCodesForDistributedSystemMXBeanTest.java
>  8b7edbf 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ShiroCacheStartRule.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/unsafe/ReadOpFileAccessControllerJUnitTest.java
>  9e355b6 
>   
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationDUnitTest.java
>  711be43 
>   
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationTestCase.java
>  7a4308f 
>   
> geode-core/src/test/java/com/gemstone/gemfire/security/DeltaClientPostAuthorizationDUnitTest.java
>  dcc087b 
>   
> geode-core/src/test/java/com/gemstone/gemfire/security/templates/XmlAuthorization.java
>  2153fb4 
>   geode-core/src/test/java/com/gemstone/gemfire/test/dunit/VM.java eb52ffc 
>   
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/excludedClasses.txt
>  d5682a6 
>   
> geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt
>  222e63d 
>   
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/security/auth1.json
>  7d62979 
>   
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/security/auth3.json
>  274eb89 
>   
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/security/cacheServer.json
>  PRE-CREATION 
>   
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/security/testSimpleUserAndRole.json
>  3f81f2d 
>   
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/security/testUserAndRoleRegionServerGroup.json
>  53f4987 
>   
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/security/testUserMultipleRole.json
>  4ff5413 
>   geode-core/src/test/resources/shiro.ini PRE-CREATION 
>   
> geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ClientCommandsDUnitTest.java
>  e551dce 
>   
> geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DurableClientCommandsDUnitTest.java
>  b35538d 
>   
> geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/DescribedExternalResource.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/LuceneFunctionReadPathDUnitTest.java
>  f6fcf8a 
>   geode-pulse/build.gradle 862bacb 
>   
> geode-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/PulseAppListener.java
>  dd3b7b7 
>   
> geode-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/controllers/PulseController.java
>  35a0b69 
>   
> geode-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/Cluster.java
>  dd89cdb 
>   
> geode-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/JMXDataUpdater.java
>  825b4a5 
>   
> geode-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/PulseConstants.java
>  c2999f8 
>   
> geode-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/Repository.java
>  5b5799d 
>   
> geode-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/log/PulseLogWriter.java
>  29304dd 
>   
> geode-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/security/GemFireAuthentication.java
>  PRE-CREATION 
>   
> geode-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/security/GemFireAuthenticationProvider.java
>  PRE-CREATION 
>   
> geode-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/security/LogoutHandler.java
>  PRE-CREATION 
>   geode-pulse/src/main/resources/pulse.properties 439e4b8 
>   geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 85de9f1 
>   
> geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/controllers/PulseControllerJUnitTest.java
>  38bf9c4 
>   
> geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/testbed/driver/PulseUITest.java
>  221be7f 
>   
> geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/DataBrowserResultLoader.java
>  3583bba 
>   
> geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAbstractTest.java
>  PRE-CREATION 
>   
> geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAuthTest.java
>  PRE-CREATION 
>   
> geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAutomatedTest.java
>  88f3b30 
>   
> geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseBaseTest.java
>  9f5523a 
>   
> geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseNoAuthTest.java
>  PRE-CREATION 
>   
> geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTest.java 
> 08cde44 
>   geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/Server.java 
> 02c7e3a 
>   geode-pulse/src/test/resources/pulse-auth.json PRE-CREATION 
>   
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WANCommandTestBase.java
>  719fd92 
>   
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandCreateGatewayReceiverDUnitTest.java
>  d9a551b 
>   
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandCreateGatewaySenderDUnitTest.java
>  d5c4b75 
>   
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewayReceiverStartDUnitTest.java
>  5edd3d2 
>   
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewayReceiverStopDUnitTest.java
>  d7bb6c3 
>   
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewaySenderStartDUnitTest.java
>  ecc6cec 
>   
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandGatewaySenderStopDUnitTest.java
>  a90b984 
>   
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandListDUnitTest.java
>  bcab986 
>   
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandPauseResumeDUnitTest.java
>  b54b27f 
>   
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WanCommandStatusDUnitTest.java
>  7293963 
>   
> geode-web/src/test/java/com/gemstone/gemfire/management/internal/web/controllers/support/EnvironmentVariablesHandlerInterceptorJUnitTest.java
>  08791c0 
>   gradle/dependency-versions.properties f89f281 
> 
> Diff: https://reviews.apache.org/r/46705/diff/
> 
> 
> Testing
> -------
> 
> precheckin, security.bt
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Reply via email to