----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46837/ -----------------------------------------------------------
Review request for geode, Jens Deppe and Kirk Lund. Repository: geode Description ------- Merge branch 'develop' into feature/GEODE-17-2 GEODE-17: enhance the GeodeSecurityUtil and review changes * allow operations that does not require any authorizations * put/get, import/export and locate entry will check region access * rename EnvronmentVariablesHandlerInterceptor * rename ShiroUtil to GeodeSecurityUtil * reformat code and review changes Diffs ----- geode-core/src/main/java/com/gemstone/gemfire/cache/operations/OperationContext.java dd290c5d6b67738b24872b29f4ad08cac7944bc9 geode-core/src/main/java/com/gemstone/gemfire/management/DistributedSystemMXBean.java a27d92f96b083f700cf0dc356c9c522f737bc861 geode-core/src/main/java/com/gemstone/gemfire/management/MemberMXBean.java 5f656a935883897d20c1b650c04ef12357c66413 geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java cdbd3db5983fdb67221125a9e14e5cb2d69a6870 geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/DataCommands.java c1c04a31b73732511531bbfda1f4c9c58dc5624f geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/RegionCommands.java ac69d32a3061e8857c94de6577731ee5e572b2ac geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/remote/CommandProcessor.java 87053ccecf155a40a1528715119da4d0c29a85fd geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/AccessControlMBean.java 992153842e325c3ab228ff7642ff614185392f6b geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/MBeanServerWrapper.java bbc044239f6cae631d3b15b2d61de4ef21743a7a geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/ResourceOperation.java f72a83524332ad33aa1e2a91b5aa5072c9b721ff geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/ResourceOperationContext.java 396cdace6dc7dc633db71c72e72bce14b94263b7 geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/AbstractCommandsController.java 211d0b1b785807e6046f6b9a8fe35121379ac595 geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/support/EnvironmentVariablesHandlerInterceptor.java bb7a27d4c6639e20f0f41e2c594a30632338ad25 geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/shell/RestHttpOperationInvoker.java 439e2b4397cf82df172a257faf1469e1984d5a57 geode-core/src/main/java/com/gemstone/gemfire/security/CustomAuthRealm.java 76fc8521772c5cf073dd23dae607b1ab818e3014 geode-core/src/main/java/com/gemstone/gemfire/security/JMXShiroAuthenticator.java 8f86c38b4fd377082305c14756b8772c71abc9e4 geode-core/src/main/java/com/gemstone/gemfire/security/ShiroUtil.java 01914e42f56b89552f23ef8801139e5288de377e geode-core/src/test/java/com/gemstone/gemfire/internal/cache/FixedPRSinglehopDUnitTest.java 61ea97a7112de029232a97eb997830392445b599 geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/CacheServerMBeanAuthorizationJUnitTest.java baa8393bff6989145d14c5a9808c0fa53e8b8a9c geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/CacheServerMBeanShiroJUnitTest.java e55623d4103367c095ea82303ba172adc71c8b2b geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/CliCommandsSecurityTest.java 5e49f9270bd67f1468f87a57b9bfafa719816982 geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/DataCommandsSecurityTest.java 7517f498bf4648a975b3e59b1736d3ba3203172f geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java f2487367f6b8b7f747bdd641dc071acf57c2157f geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GatewayReceiverMBeanSecurityTest.java b28069f560d4ce68036a689444df2cd4733fa2d5 geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GatewaySenderMBeanSecurityTest.java 3a9412dab7f16595a02ac02d3e095525a5cc942b geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodeSecurityUtilCustomRealmJUnitTest.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodeSecurityUtilWithIniFileJUnitTest.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GfshCommandsSecurityTest.java 56d70308acf131d5a093ac25c4d6de5af5396835 geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthorization.java 48e0a394b1bba1495609e7b4dfe736b4bb742fcd geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/LockServiceMBeanAuthorizationJUnitTest.java b4b3f729af0b3bfc5ae80ad171159542f49fff93 geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ManagerMBeanAuthorizationJUnitTest.java 2548d211874731c2feb07d7bf3adcfe3dd81a7fa geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/MemberMBeanSecurityJUnitTest.java c5ff369c2a91f11a4e403915989abc490fbfad26 geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ResourceOperationContextJUnitTest.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java c25044de02bbf6bd211401e3b556311d143d9ced geode-core/src/test/resources/com/gemstone/gemfire/management/internal/security/auth3.json cfd43f5145aafa0c4ef3528962a1c015ac43695c geode-core/src/test/resources/com/gemstone/gemfire/management/internal/security/cacheServer.json 01c9fd6c4ddeb004ca8e702f7ebbf51430e141ac geode-core/src/test/resources/com/gemstone/gemfire/management/internal/security/shiro-ini.json PRE-CREATION geode-core/src/test/resources/com/gemstone/gemfire/management/internal/security/testInheritRole.json 3053a9257cad2461e06e145741794993ecdd973f geode-core/src/test/resources/com/gemstone/gemfire/management/internal/security/testSimpleUserAndRole.json 0542cf45e7ea81a8573b6ded169f6809844eeec5 geode-core/src/test/resources/com/gemstone/gemfire/management/internal/security/testUserAndRoleRegionServerGroup.json 6bb28bf7cc80a584582073924e2d4ce927eb7507 geode-core/src/test/resources/com/gemstone/gemfire/management/internal/security/testUserMultipleRole.json 7a07a21e48d798557587be0c33949f35cd7aca70 geode-core/src/test/resources/shiro.ini 37b81b2446d434eec2cc911c4367671491163832 geode-junit/src/main/java/com/gemstone/gemfire/test/junit/rules/DescribedExternalResource.java 543b7fc8dd3a61cddff451e207f6c5aba97ab025 geode-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/security/GemFireAuthentication.java 5253f2f1f96429cadf626030bc8c1d053293524e geode-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/security/GemFireAuthenticationProvider.java 548c3a5188fd0442bf4250b222c7a252263c02b2 geode-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/security/LogoutHandler.java a70925d87a6ebd3e8e0a40a13cc2b51e50ffd004 geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAbstractTest.java 392de4c80e018788b69aa877c9c99a801157e8d9 geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/Region.java 1770dd522020f117d76cdcd426d628279c4474e0 geode-web/src/main/webapp/WEB-INF/gemfire-servlet.xml eb1a53395bdf055e39d709182092f45da07a25cf geode-web/src/test/java/com/gemstone/gemfire/management/internal/web/controllers/support/EnvironmentVariablesHandlerInterceptorJUnitTest.java 4b9e30329db6e8f5525c150bab969735cd388e9b Diff: https://reviews.apache.org/r/46837/diff/ Testing ------- precheckin, uiTest Thanks, Jinmei Liao
