----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47220/#review132695 -----------------------------------------------------------
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/Simple2CacheServerDUnitTest.java (line 39) <https://reviews.apache.org/r/47220/#comment196962> How about changing the name to SimpleTwoCacheServerDUnitTest? Within the words number 2 generally refers to "To"...But its upto you... geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/Simple2CacheServerDUnitTest.java (line 78) <https://reviews.apache.org/r/47220/#comment196963> Unsetting of the callback flag needs to be called even if there is any failure, right? If thats the case, do we need to wrap this in a finally block? geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/Simple2CacheServerDUnitTest.java (line 83) <https://reviews.apache.org/r/47220/#comment196964> From the above it looks like we are not sure which one is the primary queue server...Are we expecting to close primary queue server or any server? - anilkumar gingade On May 11, 2016, 6:05 a.m., xiaojian zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47220/ > ----------------------------------------------------------- > > (Updated May 11, 2016, 6:05 a.m.) > > > Review request for geode and anilkumar gingade. > > > Bugs: geode-1344 > https://issues.apache.org/jira/browse/geode-1344 > > > Repository: geode > > > Description > ------- > > There're more than one thread that are try to connect and create proxy for > durable client. It's possible that the reinitialize() is called more than > once. But it should be at least once. > > I did not change the product code for durable client. It's my test code used > wrong expectation. > > > Diffs > ----- > > > geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/Simple2CacheServerDUnitTest.java > 4fdd88d > > Diff: https://reviews.apache.org/r/47220/diff/ > > > Testing > ------- > > > Thanks, > > xiaojian zhou > >
