> On May 12, 2016, 3:02 p.m., Bruce Schuchardt wrote: > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java, > > line 2186 > > <https://reviews.apache.org/r/47245/diff/1/?file=1379798#file1379798line2186> > > > > wouldn't it be simpler to pass a copy of "unresponsive" to > > removeHealthyMembers? Then you wouldn't have to synchronize on > > viewRequests.
We need to use "unresponsive" set after removeHealthyMembers call. removeHealthyMembers call updates "unresponsive" set and need to operate on that only. Thus once we return from removeHealthyMembers call, we should be operating on another copy of "unresponsive" set as other threads in removeHealthyMembers may be still accessing it. - Hitesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47245/#review132924 ----------------------------------------------------------- On May 11, 2016, 5:55 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47245/ > ----------------------------------------------------------- > > (Updated May 11, 2016, 5:55 p.m.) > > > Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > Now parent thread process copy of unResponsive members > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 88e4d49 > > Diff: https://reviews.apache.org/r/47245/diff/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
