----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47004/#review133393 -----------------------------------------------------------
Fix it, then Ship it! Ship It! geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java (line 86) <https://reviews.apache.org/r/47004/#comment197784> Do we need to say about advanced version? geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java (line 88) <https://reviews.apache.org/r/47004/#comment197776> We need to define this in LunceneIndex interface to be used as public API. geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java (line 89) <https://reviews.apache.org/r/47004/#comment197779> I believe in our group session we passed two arguments. 1. Max wait time 1. Unit of sleep (iunstead of hard coded 200 mili sec) - anilkumar gingade On May 16, 2016, 5:39 a.m., xiaojian zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47004/ > ----------------------------------------------------------- > > (Updated May 16, 2016, 5:39 a.m.) > > > Review request for geode, anilkumar gingade and Dan Smith. > > > Bugs: geode-1351 > https://issues.apache.org/jira/browse/geode-1351 > > > Repository: geode > > > Description > ------- > > This is for test purpose. > > An advanced version will be implemented later using function execution. > > > Diffs > ----- > > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneEventListener.java > 9fdfd43 > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java > 0b5f8fa > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesBase.java > c467a18 > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImplJUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/47004/diff/ > > > Testing > ------- > > > Thanks, > > xiaojian zhou > >
