> On May 18, 2016, 12:16 a.m., anilkumar gingade wrote: > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplIntegrationTest.java, > > line 321 > > <https://reviews.apache.org/r/47496/diff/1/?file=1386143#file1386143line321> > > > > How about moving these puts into region initialization method?
I left it this way for now because I think there will be cases where we want to create a region with different data and not necessarily have the same data every time. Each test can specifically tune the data they want to use and expect. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47496/#review133663 ----------------------------------------------------------- On May 17, 2016, 10:54 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47496/ > ----------------------------------------------------------- > > (Updated May 17, 2016, 10:54 p.m.) > > > Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan > Smith, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Added integration tests to test three scenarios: > 1.) the lucene indexes are not updated during an in flight transaction (begin > but before rollback or commit) > 2.) the lucene indexes are updated after a commit > 3.) the lucene indexes are not changed after a rollback > > todo: > Do we want to add a dunit test for multiple vms and threads doing > transactions? I avoided adding this test for now as I thought that was more > of a "testing the geode transaction feature" rather than testing how the > feature affects lucene. > > > Diffs > ----- > > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplIntegrationTest.java > fa3392c > > Diff: https://reviews.apache.org/r/47496/diff/ > > > Testing > ------- > > > Thanks, > > Jason Huynh > >
