----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47908/#review135020 -----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java (line 86) <https://reviews.apache.org/r/47908/#comment200008> You should get rid of "synchronized" on the methods. Others look good. Fit it and ship it. - xiaojian zhou On May 26, 2016, 5:23 p.m., Jianxia Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47908/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 5:23 p.m.) > > > Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh > Khamesra, Udo Kohlmeyer, Dan Smith, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Add a lock to synchronize two getInstance methods, so that they return either > null ccnSingleton or fully initialized ccnSingleton, i.e. haContainer is not > null if it is not gateway receiver. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java > 80d05ba > > Diff: https://reviews.apache.org/r/47908/diff/ > > > Testing > ------- > > > Thanks, > > Jianxia Chen > >
