> On May 24, 2016, 9:44 p.m., Dan Smith wrote: > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProvider.java, > > line 70 > > <https://reviews.apache.org/r/47686/diff/2/?file=1392007#file1392007line70> > > > > The javadocs for setAllowLeadingWildercard say this: "Note that this > > can produce very slow queries on big indexes." > > > > Is this something we really want to enable?
This is a very useful option to fetch all the data from the lucene index...In database its common to use "select all"...It could be expensive based on the index data size, as this is similar to table scan....I could not find any place saying this will impact other queries...If you don't see need of this, I am fine with removing this... - anilkumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47686/#review134641 ----------------------------------------------------------- On May 24, 2016, 12:05 a.m., anilkumar gingade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47686/ > ----------------------------------------------------------- > > (Updated May 24, 2016, 12:05 a.m.) > > > Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan > Smith, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > GEODE-11: Added changes to Lucene AEQ, to propagate destroy events due to > eviction and expiration (by setting the flag ignoreEvictionAndExpiration()). > > Added test to verify, the lucene index gets updated with expiration destroy > operation. > Also added support to specify wild-char as leading wild character with Lucene > Query. > > > Diffs > ----- > > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java > d22ca4a196df3b1a457b56c92da694bdbf792cc2 > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProvider.java > 1e2b63d0fc5c7fad79063199c473bbd9d4e6fd00 > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java > 07780ca06a297851c8ff4cb498a09f726a0785d5 > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java > 15f5747231097df5223d97bb49110229efe6a824 > > Diff: https://reviews.apache.org/r/47686/diff/ > > > Testing > ------- > > > Thanks, > > anilkumar gingade > >
