----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48652/ -----------------------------------------------------------
Review request for geode, Darrel Schneider and Swapnil Bawaskar. Bugs: GEODE-1517 https://issues.apache.org/jira/browse/GEODE-1517 Repository: geode Description ------- Holding the ReentrantLock during TXManagerImpl.close() when closing TXStateProxyImpl. Provent any TXStateProxyImpl to work further. Add a test case where it fails without the above fix and passes after the fix. Also avoid going through synchronized failover map to check if a TXStateProxyImpl is finished, instead, use its isInProgress() call. Diffs ----- geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteOperationMessage.java 19e1dea geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java 2608878 geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java 1b83ee3 geode-core/src/test/java/com/gemstone/gemfire/internal/cache/RemoteOperationMessageTest.java ecfc2b0 geode-core/src/test/java/com/gemstone/gemfire/internal/cache/TXManagerImplTest.java ce24947 geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessageTest.java bbbf714 Diff: https://reviews.apache.org/r/48652/diff/ Testing ------- precheckin Thanks, Eric Shu