----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48431/#review137346 -----------------------------------------------------------
Ship it! This change looks good. I think your change makes possible a change to SampleCollector.sampleResources to no longer call getStatistics (which copies the list into an array) but to instead just iterate the list like everyone else does. You could make this change yourself or file a ticket to do it in the future. - Darrel Schneider On June 8, 2016, 11:06 a.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48431/ > ----------------------------------------------------------- > > (Updated June 8, 2016, 11:06 a.m.) > > > Review request for geode, Darrel Schneider, Jinmei Liao, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > The statsList used to track Statistics in InternalDistributedSystem was > managed under a lock. That was problematic, because code that iterates > on the list needs to hold the lock. If the code invoking callbacks for > GEODE-1494 was slow, that means the lock would block other stats > operations. > > Changing this list to a copy on write array list to holding a lock for a > long period of time. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java > af81cc1b770bd323f3977a865ee3280a55146b3c > > geode-core/src/main/java/com/gemstone/gemfire/internal/AbstractStatisticsFactory.java > 886258b0589fd291411d11425b9a06713142a384 > > geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireStatSampler.java > 59305066429c0bb020b7795afec1bfdf260d08b5 > geode-core/src/main/java/com/gemstone/gemfire/internal/HostStatSampler.java > ebb4177c12f6d67ef2cafb76d7a3d765fb1139ea > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/control/HeapMemoryMonitor.java > 90a26cbada03ea49cd769c83c9538eb7654466ed > > Diff: https://reviews.apache.org/r/48431/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
