----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48701/#review137564 -----------------------------------------------------------
Nice. Maybe it would be better to have a different method to verify the values of the results? I don't think it makes sense to pass a new flag into verifyQueryKeys that is specific to this json test. - Dan Smith On June 14, 2016, 6:06 p.m., xiaojian zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48701/ > ----------------------------------------------------------- > > (Updated June 14, 2016, 6:06 p.m.) > > > Review request for geode and Dan Smith. > > > Bugs: GEODE-1545 > https://issues.apache.org/jira/browse/GEODE-1545 > > > Repository: geode > > > Description > ------- > > add a test case > > > Diffs > ----- > > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java > c26997d > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/LuceneTestUtilities.java > 0cf8953 > > Diff: https://reviews.apache.org/r/48701/diff/ > > > Testing > ------- > > > Thanks, > > xiaojian zhou > >
