Github user jhuynh1 commented on the issue:
https://github.com/apache/incubator-geode/pull/171
Some minor improvements/corrections:
1.) remove @author tag from Consumer.java
2.) The test checkIfScriptsAreExecutable runs the same line twice. I think
the second line was supposed to check the stop scripts and not the start scripts
3.) In one of the tests, we probably should check that Consumer.NUM_ENTRIES
is > 0. Just incase someone accidentally changes it to 0, the tests would pass
but not really execute what the producer and consumer tests were expecting.
4.) preference/style : Perhaps some of the test names can be slightly more
descriptive just so we know what the behavior should be.. such as changing
populateWhenRegionDoesntExist to
populateWhenRegionDoesNotExistShouldThrowNullPointer?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
