----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49772/#review141227 -----------------------------------------------------------
Ship it! Ship It! - xiaojian zhou On July 7, 2016, 10:39 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49772/ > ----------------------------------------------------------- > > (Updated July 7, 2016, 10:39 p.m.) > > > Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan > Smith, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > The test was failing on a negative check to make sure the queue actually had > contents. There were cases where the queue could be drained due to the > "slowness"/async pausing of the sender. > > I also moved and rewrote this test out from LuceneQueriesBase as I didn't > think we needed to test flushing on multiple base region types. Not sure if > commits stat is the correct one to check. The docs stat was returning 0. > > Also noticed that the pdx -> jsonstring conversion done in > LuceneTestUtilities wasn't actually using the converted jsonstring. Instead > we could avoid that entire if statement altogether. > > > Diffs > ----- > > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java > 7d7fa3d > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesBase.java > e817d3b > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/LuceneTestUtilities.java > 8aca11c > > Diff: https://reviews.apache.org/r/49772/diff/ > > > Testing > ------- > > geode-lucene:precheckin > > > Thanks, > > Jason Huynh > >
