----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49901/#review141732 -----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/Transport.java (line 139) <https://reviews.apache.org/r/49901/#comment207091> seems length == 0 is enough here.. - Hitesh Khamesra On July 11, 2016, 3:49 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49901/ > ----------------------------------------------------------- > > (Updated July 11, 2016, 3:49 p.m.) > > > Review request for geode, Hitesh Khamesra and Udo Kohlmeyer. > > > Bugs: GEODE-1642 > https://issues.apache.org/jira/browse/GEODE-1642 > > > Repository: geode > > > Description > ------- > > This adds a new method, isCancelInProgress(), to CancelCriterion. Most uses > of the method cancelInProgress() have now been changed to use the new method. > > This also includes a fix for GEODE-1596, an IndexOutOfBoundsException suspect > string in JGroups. > > > Diffs > ----- > > geode-core/src/main/java/com/gemstone/gemfire/CancelCriterion.java > 03fadb07b7295ef6ebd785054cb2eeaae05b3035 > > geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/AutoConnectionSourceImpl.java > 985b4c31ffb9894b13b6ec512875e19a266347c5 > > geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/DataSerializerRecoveryListener.java > ef471c82f65dd20df851cebbf618af08daa0f3e2 > > geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/EndpointManagerImpl.java > 8b4e08a3ba808d5f0db14b1dbef7150893554b1d > > geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/InstantiatorRecoveryListener.java > 16f7e6087537cdf8820ec0b1401bcf494301963f > > geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/LiveServerPinger.java > 1ab09dafd780daf77c70a35ea4e6f0c92b4730b9 > > geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/QueueStateImpl.java > 382d4a947f13d463c786ea22b3648f572d9a3eec > > geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/RegisterInterestTracker.java > 5c48ecedf98642337d6fe99009d8427c43f8c5cc > > geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerImpl.java > a3f5e3b19a8b9466f31bdc054bca71b826bce705 > > geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/IndexManager.java > 82b88606b8fdc3390ecdcd9ef6186bdb2813d0a0 > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java > 29a9da702b31af2709e475c1a973f08cbf352464 > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java > 14a4d53a94fc7b104f69e12d46998bbd7c287ef2 > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/direct/DirectChannel.java > f1caa5daf5cddf6df9d9dd9d7db57fe2461ce19b > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/locks/DLockGrantor.java > d02580e803af080109544f9897516c0b267f262b > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/locks/DLockService.java > 5e9d3c52f7cc71eb13c368499760bd8c65722613 > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/Services.java > bc591803a3ea72680e1f74332416b457d330584a > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 87fac5333ff631916ef407f3e825a91672099180 > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/Transport.java > 167193f4b33f99710cd729ee6575fcde813c9ef9 > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java > 72e0118aa16e22897e22f5dcf14eb1ac6a3800c1 > geode-core/src/main/java/com/gemstone/gemfire/internal/HostStatSampler.java > 38fc83dd70e18751fd9e32a42acd9132466f3280 > > geode-core/src/main/java/com/gemstone/gemfire/internal/admin/StatAlertsManager.java > 90d00e448a3b8a0ffa4ee4012a688cd6d2577728 > > geode-core/src/main/java/com/gemstone/gemfire/internal/admin/remote/FetchHostResponse.java > 949e5adab55baf886a70113b9755d4a5720a3b45 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java > d085c5213351377ef30c5f5bb3d8c52cfa9389bd > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java > b32927e9747af05544d5bd097e44f82966a2e111 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskStoreImpl.java > 6c963e6f8c46490ceb7939f444bc7ab2c820c4cb > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegionFunctionStreamingMessage.java > af54945a7d2fcce0db245651033a1d1d11ff7bae > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/MemberFunctionStreamingMessage.java > 3e05df2b9ce7bb42d9051e7d778ed242d39ee977 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PRHARedundancyProvider.java > c33efb7dcb5fe76c2fbe6354a7276a03c1efbc7c > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java > 39230c4ac6fb31668e09ee20499e6656a0b0de95 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegionHelper.java > 8fe8f45007f3e50971df3453ce301f49151f2d91 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXSynchronizationRunnable.java > c4a40f71d5648570eb63d51bbdb3ff370bb85439 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TombstoneService.java > dca792f3b03c451019e5c7ebaee960a7fb446170 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueue.java > c5746edc2ea102a40364fb32b34caac98d228a70 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/locks/TXLockServiceImpl.java > b32d3a5bccb0d58df2c5b80b8201ac14fed57de2 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RecoveryRunnable.java > 93d5e616535fba2f3c23fc391de46cab6fb52eae > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/RegionAdvisor.java > a5b4d71fb4f41ce4bcf2ffb054309d81959632ec > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/CachedRegionHelper.java > 8897dd7608f0763c6e2fe6786eeffb28613e9aa7 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/AcceptorImpl.java > b6d19f9713942a26b2a132098e23fe803363cb95 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientProxy.java > 92a668feab4be35eb6992a3508c914d3a498954e > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientUpdater.java > 28b789a7ded965abf29bc956b9549fff59e04813 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/ServerConnection.java > 37c60346238799697a7654e8d1cae6e81ca8642d > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java > e3a3d531d672139f62232ac4c325148a9f9d7e88 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java > ce08e8d1a37c04e896c403b939a1eab1b65bf9ef > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderAdvisor.java > 8efd5fc8d1822fad7dbeb3cdfda30f117e05401c > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java > 453e7f040e71de279413a7f0afd5cd0585f9d9a0 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderQueue.java > b516ca10527eff4131fc590806e2ebc6a2fb415c > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/CallbackSampler.java > 0180fba1e8c062e77d234d4a2620f4e979eac357 > geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java > 6528877789835d0c12431348ccd7a86c40629525 > geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/TCPConduit.java > ed570c1d5eddb74de799f95f8672496777250c41 > > geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/AutoConnectionSourceDUnitTest.java > ff2f6fac17cf54d860b89e81b1c927646b136d92 > > geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManagerJUnitTest.java > ba9be84f25d1344b290c55edc1dc3a68d6dcdc0a > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/SystemFailureDUnitTest.java > 0d1fea9d10dbe438136c8399e16238205375dfa7 > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/CallbackSamplerJUnitTest.java > 9109ba79062bcf1a9e707516292db2cac5906192 > > geode-core/src/test/java/com/gemstone/gemfire/test/dunit/cache/internal/JUnit4CacheTestCase.java > 73218e091c8302055411af57c8e4ecece45a869b > > geode-cq/src/main/java/com/gemstone/gemfire/cache/query/internal/cq/CqServiceImpl.java > fa90e889c55a115a66c1030b71d63e82ee4fb41b > > geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java > b1781927974eabf871aaf0e138a8a25c3ffcbbf8 > > Diff: https://reviews.apache.org/r/49901/diff/ > > > Testing > ------- > > Precheckin > > > Thanks, > > Bruce Schuchardt > >
