GitHub user gracemeilen opened a pull request:
https://github.com/apache/incubator-geode/pull/195
GEODE-1598: fix auto-completion problems
Spring shell, jopt-simple and Geode GFSH code all duplicated the concept of
required options. jopt-simple can be blind to this, which prevents
OptionParser.parse from throwing an Exception when a required option is missing
at time of hitting tab for auto-complete. This allows OptionParser to return an
OptionSet containing all detected options which is necessary for
auto-completion to behave correctly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gracemeilen/incubator-geode
feature/GEODE-1598-3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/195.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #195
----
commit a81d5cb6130c7bdf94851975069056e151e8daf9
Author: gmeilen <[email protected]>
Date: 2016-07-11T20:45:39Z
GEODE-1598: fix auto-completion problems by telling jopt that all options
are optional
Spring shell, jopt-simple and Geode GFSH code all duplicated the concept of
required options. jopt-simple can be blind to this, which prevents
OptionParser.parse from throwing an Exception when a required option is missing
at time of hitting tab for auto-complete. This allows OptionParser to return an
OptionSet containing all detected options which is necessary for
auto-completion to behave correctly.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
