I'll revert it. I ran precheckin on concourse, and it doesn't show me that failure.... Maybe I wasn't doing it right...?
On Mon, Jul 18, 2016 at 11:04 AM, Anthony Baker <aba...@pivotal.io> wrote: > I’m seeing some unit test failures on the head of /develop: > > :geode-core:test > > com.gemstone.gemfire.distributed.internal.membership.gms.auth.GMSAuthenticatorJUnitTest > > testGetCredentialNormal FAILED > com.gemstone.gemfire.security.GemFireSecurityException: > java.lang.IllegalAccessException: Class > com.gemstone.gemfire.internal.security.GeodeSecurityUtil can not access a > member of class > com.gemstone.gemfire.distributed.internal.membership.gms.auth.GMSAuthenticatorJUnitTest$TestAuthInit2 > with modifiers "public static" > at > com.gemstone.gemfire.internal.security.GeodeSecurityUtil.getObjectOfTypeFromFactoryMethod(GeodeSecurityUtil.java:421) > at > com.gemstone.gemfire.internal.security.GeodeSecurityUtil.getObjectOfType(GeodeSecurityUtil.java:439) > at > com.gemstone.gemfire.distributed.internal.membership.gms.auth.GMSAuthenticator.getCredentials(GMSAuthenticator.java:199) > at > com.gemstone.gemfire.distributed.internal.membership.gms.auth.GMSAuthenticatorJUnitTest.testGetCredentialNormal(GMSAuthenticatorJUnitTest.java:89) > > Caused by: > java.lang.IllegalAccessException: Class > com.gemstone.gemfire.internal.security.GeodeSecurityUtil can not access a > member of class > com.gemstone.gemfire.distributed.internal.membership.gms.auth.GMSAuthenticatorJUnitTest$TestAuthInit2 > with modifiers "public static" > at > sun.reflect.Reflection.ensureMemberAccess(Reflection.java:102) > at > java.lang.reflect.AccessibleObject.slowCheckMemberAccess(AccessibleObject.java:296) > at > java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:288) > at java.lang.reflect.Method.invoke(Method.java:491) > at > com.gemstone.gemfire.internal.security.GeodeSecurityUtil.getObjectOfTypeFromFactoryMethod(GeodeSecurityUtil.java:413) > ... 3 more > > com.gemstone.gemfire.distributed.internal.membership.gms.auth.GMSAuthenticatorJUnitTest > > testGetCredentialWithInitError FAILED > java.lang.AssertionError > at org.junit.Assert.fail(Assert.java:86) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertTrue(Assert.java:52) > at > com.gemstone.gemfire.distributed.internal.membership.gms.auth.GMSAuthenticatorJUnitTest.verifyNegativeGetCredential(GMSAuthenticatorJUnitTest.java:137) > at > com.gemstone.gemfire.distributed.internal.membership.gms.auth.GMSAuthenticatorJUnitTest.testGetCredentialWithInitError(GMSAuthenticatorJUnitTest.java:123) > > com.gemstone.gemfire.distributed.internal.membership.gms.auth.GMSAuthenticatorJUnitTest > > testGetCredentialWithNullAuth FAILED > java.lang.AssertionError > at org.junit.Assert.fail(Assert.java:86) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertTrue(Assert.java:52) > at > com.gemstone.gemfire.distributed.internal.membership.gms.auth.GMSAuthenticatorJUnitTest.verifyNegativeGetCredential(GMSAuthenticatorJUnitTest.java:137) > at > com.gemstone.gemfire.distributed.internal.membership.gms.auth.GMSAuthenticatorJUnitTest.testGetCredentialWithNullAuth(GMSAuthenticatorJUnitTest.java:117) > > com.gemstone.gemfire.distributed.internal.membership.gms.auth.GMSAuthenticatorJUnitTest > > testGetCredentialWithError FAILED > java.lang.AssertionError > at org.junit.Assert.fail(Assert.java:86) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertTrue(Assert.java:52) > at > com.gemstone.gemfire.distributed.internal.membership.gms.auth.GMSAuthenticatorJUnitTest.verifyNegativeGetCredential(GMSAuthenticatorJUnitTest.java:137) > at > com.gemstone.gemfire.distributed.internal.membership.gms.auth.GMSAuthenticatorJUnitTest.testGetCredentialWithError(GMSAuthenticatorJUnitTest.java:129) > > com.gemstone.gemfire.distributed.internal.membership.gms.auth.GMSAuthenticatorJUnitTest > > testGetCredentialWithNotExistAuth FAILED > java.lang.AssertionError > at org.junit.Assert.fail(Assert.java:86) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertTrue(Assert.java:52) > at > com.gemstone.gemfire.distributed.internal.membership.gms.auth.GMSAuthenticatorJUnitTest.verifyNegativeGetCredential(GMSAuthenticatorJUnitTest.java:137) > at > com.gemstone.gemfire.distributed.internal.membership.gms.auth.GMSAuthenticatorJUnitTest.testGetCredentialWithNotExistAuth(GMSAuthenticatorJUnitTest.java:111) > > > Here’s the latest commits: > > commit e72831ecb25259ed6ec3879f555c1dc8b872264f > Author: Jinmei Liao <jil...@pivotal.io> > Date: Thu Jul 14 22:41:58 2016 -0700 > > GEODE-1571: simplify security check > > commit d200d70845649d14b71dab67ee17826017194e80 > Author: Jinmei Liao <jil...@pivotal.io> > Date: Wed Jul 13 16:30:21 2016 -0700 > > GEODE-1571: have auth-init accept either a constructor or a static > factory method. > > commit 8341267c5ecc91a4b159844d59ec0e5317529533 > Author: Kirk Lund <kl...@pivotal.io> > Date: Fri Jul 15 13:19:53 2016 -0700 > > GEODE-1667: update CacheTestCase to JUnit 4 by default > > > Should we revert one or more of these? I think we should prioritize > getting the build green again. > > Anthony > > -- Cheers Jinmei
