Yes, I can add the call to ACE::init() if some specific environment variable is 
not defined. 

-----Original Message-----
From: metatype [mailto:g...@git.apache.org] 
Sent: Monday, July 18, 2016 18:32
To: dev@geode.incubator.apache.org
Subject: [GitHub] incubator-geode pull request #199: GEODE-88: code fixes for 
c++ client

Github user metatype commented on a diff in the pull request:

    https://github.com/apache/incubator-geode/pull/199#discussion_r71169682
  
    --- Diff: geode-client-native/src/cppcache/impl/CppCacheLibrary.cpp ---
    @@ -79,7 +84,6 @@ typedef 
ACE_Singleton<CppCacheLibrary,ACE_Recursive_Thread_Mutex> TheLibrary;
     // internals are prepared. fw_helper framework will handle this.
     CppCacheLibrary* CppCacheLibrary::initLib( void )
     {
    -  ACE::init();
    --- End diff --
    
    Won't removing the ACE::init() call affect all existing users?  That is, 
they would need to modify their applications to add the invocation directly.  I 
understand this is important for your use case.  Is there a way you could 
conditionally skip the library initialization rather than remove it entirely?



---
If your project is set up for it, you can reply to this email and have your 
reply appear on GitHub as well. If your project does not have this feature 
enabled and wishes so, or if the feature is enabled but not working, please 
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with 
INFRA.
---

This message and the information contained herein is proprietary and 
confidential and subject to the Amdocs policy statement,
you may review at http://www.amdocs.com/email_disclaimer.asp

Reply via email to