----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50276/#review143086 -----------------------------------------------------------
Ship it! Ship It! - Sai Boorlagadda On July 20, 2016, 11:43 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50276/ > ----------------------------------------------------------- > > (Updated July 20, 2016, 11:43 p.m.) > > > Review request for geode, Scott Jewell and Sai Boorlagadda. > > > Repository: geode > > > Description > ------- > > Problem was that the stop method was holding the sync on "this" while it was > joining on the thread. The thread could not wakeup until the stop thread > released the sync. > I also removed the test of sweeperThread being non-null since it is a final > variable. > Also stop no longer empties the queue since it will soon be garbage collected > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TombstoneService.java > 192e24d8770a855bc4212da312e755fdc522a064 > > Diff: https://reviews.apache.org/r/50276/diff/ > > > Testing > ------- > > perf076 and precheckin > > > Thanks, > > Darrel Schneider > >
