----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50364/ -----------------------------------------------------------
Review request for geode, anilkumar gingade, Barry Oglesby, Jens Deppe, William Markito, nabarun nag, Dan Smith, and xiaojian zhou. Repository: geode Description ------- Currently, we do not support Tomcat 8.5.4. This is a first cut attempt to at doing so. This patch will probably have a lot of debug statements to clean up as well as cleaning up a bunch of code. This is the diff right after getting everything compiling and manually tested. Extracted DeltaSession into an interface, this allowed us to keep support for Tomcat 6 and 7 -- This was needed because the value attributes is now a ConcurrentMap and no longer a Map Refactored LifecycleListener and moved it to the specific DeltaSessionManagers as it no longer exists in Tomcat 8 Created new EmbeddedTomcat as the old Embedded class is no longer present in Tomcat 8 Setup of tests needed to be changed because a lot of the setup code is no longer needed or needed in a different order Diffs ----- extensions/geode-modules-assembly/build.gradle 412ba09 extensions/geode-modules-tomcat7/src/main/java/com/gemstone/gemfire/modules/session/catalina/Tomcat7DeltaSessionManager.java d1f44bb extensions/geode-modules-tomcat8/build.gradle PRE-CREATION extensions/geode-modules-tomcat8/src/main/java/com/gemstone/gemfire/modules/session/catalina/DeltaSession8.java PRE-CREATION extensions/geode-modules-tomcat8/src/main/java/com/gemstone/gemfire/modules/session/catalina/Tomcat8DeltaSessionManager.java PRE-CREATION extensions/geode-modules-tomcat8/src/test/java/com/gemstone/gemfire/modules/session/EmbeddedTomcat8.java PRE-CREATION extensions/geode-modules-tomcat8/src/test/java/com/gemstone/gemfire/modules/session/TestSessionsTomcat8Base.java PRE-CREATION extensions/geode-modules-tomcat8/src/test/java/com/gemstone/gemfire/modules/session/Tomcat8SessionsJUnitTest.java PRE-CREATION extensions/geode-modules-tomcat8/src/test/resources/tomcat/conf/tomcat-users.xml PRE-CREATION extensions/geode-modules-tomcat8/src/test/resources/tomcat/logs/.gitkeep PRE-CREATION extensions/geode-modules-tomcat8/src/test/resources/tomcat/temp/.gitkeep PRE-CREATION extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/gatewaydelta/GatewayDeltaDestroyEvent.java 18bfe8b extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/session/bootstrap/AbstractCache.java c14f829 extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/session/catalina/CommitSessionValve.java 0ae17f2 extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/session/catalina/DeltaSession.java c81a232 extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/session/catalina/DeltaSessionFacade.java 1ac4da2 extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/session/catalina/DeltaSessionInterface.java PRE-CREATION extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/session/catalina/DeltaSessionManager.java 92d9ef6 extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/session/catalina/Tomcat6DeltaSessionManager.java d5b5991 extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/session/catalina/callback/SessionExpirationCacheListener.java dff6d58 extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/session/catalina/internal/DeltaSessionAttributeEvent.java 90b6f28 extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/session/catalina/internal/DeltaSessionAttributeEventBatch.java 47df071 extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/session/catalina/internal/DeltaSessionDestroyAttributeEvent.java 989474f extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/session/catalina/internal/DeltaSessionUpdateAttributeEvent.java 6678e55 extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/util/ContextMapper.java 3b7b2de gradle/dependency-versions.properties 196a4f8 settings.gradle ca34692 Diff: https://reviews.apache.org/r/50364/diff/ Testing ------- Thanks, Jason Huynh
