----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50304/#review143294 -----------------------------------------------------------
Ship it! can you rename tempHashIndexSetProperties to newHashIndexSetProperties, also remove the starting _ for the variable names? Lastly, computeNumFree can be added as a method into the new HashIndexSetProperties - Jason Huynh On July 21, 2016, 5:39 p.m., nabarun nag wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50304/ > ----------------------------------------------------------- > > (Updated July 21, 2016, 5:39 p.m.) > > > Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, Dan > Smith, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > * Immutable ojects pairs the mask and set together > * There is no race condition in which the mask differs from the set leading > to any ArrayOutOfBoundsException. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/HashIndexSet.java > 5ed724b > > geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/HashIndexJUnitTest.java > e2a8643 > > geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/HashIndexSetJUnitTest.java > 7f96fde > > Diff: https://reviews.apache.org/r/50304/diff/ > > > Testing > ------- > > Precheck-in with no failures. > > > Thanks, > > nabarun nag > >
