> On July 25, 2016, 11 a.m., Darrel Schneider wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXLockRequest.java,
> >  line 99
> > <https://reviews.apache.org/r/50399/diff/1/?file=1451920#file1451920line99>
> >
> >     I think it is wrong for this release method to call "createDTLS". If 
> > the TXLockService no longer exists then release should not recreate it.

I now understand that this catch is restoring some old code.
Eric is going to file a new ticket about cleaning up the callers of createDTLS 
and the life cycle of DTLS in general.


- Darrel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50399/#review143402
-----------------------------------------------------------


On July 25, 2016, 10:30 a.m., Eric Shu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50399/
> -----------------------------------------------------------
> 
> (Updated July 25, 2016, 10:30 a.m.)
> 
> 
> Review request for geode, Darrel Schneider and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Restore the original handling of the IllegalStateException in TXLockRequest
> 
> 
> Diffs
> -----
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXLockRequest.java
>  b9594d5 
> 
> Diff: https://reviews.apache.org/r/50399/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Reply via email to