----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50051/#review143453 -----------------------------------------------------------
Ship it! Ship It! - Kirk Lund On July 14, 2016, 10:19 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50051/ > ----------------------------------------------------------- > > (Updated July 14, 2016, 10:19 p.m.) > > > Review request for geode, Grace Meilen, Kevin Duling, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-1571: have auth-init accept either a constructor or a static factory > method. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/auth/GMSAuthenticator.java > b82fdb1848d4ac0c0c47fe56f6699ba0dea84fde > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/HandShake.java > a2951f5f5a31d0ad80b3407097332067bf2f6e60 > > geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java > 8707a7895355cb187e9608b8fb6af2a33b36c2fa > > geode-core/src/main/java/com/gemstone/gemfire/internal/security/shiro/CustomAuthRealm.java > 3d6275b58acdc94f94de2ed286bcb478c5b46352 > geode-core/src/main/java/com/gemstone/gemfire/security/AuthInitialize.java > 400c6654bce587fdfca0789e33f4bc37b6064b8b > geode-core/src/main/java/org/apache/geode/security/GeodePermission.java > 866b14ee591ed830387d87e6dcedab5ac6215393 > geode-core/src/main/java/org/apache/geode/security/PostProcessor.java > 0f13b47b5fc52ff176045db7d5a24f30d6158193 > > geode-core/src/main/java/org/apache/geode/security/templates/SamplePostProcessor.java > 7e078da19a5721a0a4bd79eb277b7384ecf47bd0 > > geode-core/src/test/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtilTest.java > d1dd466b64630bbf92af8b70339ca73c8417b3cb > > Diff: https://reviews.apache.org/r/50051/diff/ > > > Testing > ------- > > > Thanks, > > Jinmei Liao > >