> On July 26, 2016, 5:02 p.m., Dan Smith wrote: > > Looks good - but this does mean that the build id will always be 0 unless > > someone sets it, whereas before it was the current date. Will that be an > > issue?
AFAIK, the buildId is only used in GemFireVersion.properties. That file already has a more useful build date embedded. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50436/#review143552 ----------------------------------------------------------- On July 26, 2016, 4:56 p.m., Anthony Baker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50436/ > ----------------------------------------------------------- > > (Updated July 26, 2016, 4:56 p.m.) > > > Review request for geode, Dick Cavender, Mark Bretl, and Dan Smith. > > > Repository: geode > > > Description > ------- > > Extract the product name and org into gradle.properties. > > GEODE-1695: Add buildId to gradle.properties > > > GEODE-1695: Use productName to build javadocs > > > Diffs > ----- > > extensions/geode-modules-assembly/build.gradle > 412ba096b74b5de4bf6af2b09f66774f4fdf00ed > geode-assembly/build.gradle c410f594dac3ac315c0eed2ff8c00d9f061ed473 > geode-core/build.gradle 030885eae9f681b4438faebe787091929b35ce4a > gradle.properties 0fa3765d1b49b7c7f193d8fcb05c328e594a3f11 > gradle/java.gradle 4acb4da8a8a3da686d6ba10a8a8d57ac7fa375be > > Diff: https://reviews.apache.org/r/50436/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Baker > >
