Github user upthewaterspout commented on the issue:
https://github.com/apache/incubator-geode/pull/217
This change is mixing internal classes in the public API. You're adding
getDefinedIndexes to the public API, but it returns LuceneIndexCreationProfile
objects which is an internal class. Looking at LuceneIndexCreationProfile, I
think these methods probably don't belong on LuceneService. Maybe put these
methods on InternalLuceneService?
I think setFieldAnalyzerStrings is not a good name, because it's not
actually setting anything on the object. Same with
setFieldAnalyzerStringsFromProfile.
The boolean "status" field in in LuceneIndexDetails is confusing - what
does true or false mean? Maybe it should be named initialized?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
