----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50420/#review143583 -----------------------------------------------------------
I'm a bit confused by this fix actually. The test calls pauseSender, puts some entries, and then calls resumeSender. pauseSender should have seen an NPE if one of these fields was null because they cache was still initializing. It seems like something must have *become* null. I ran the test with this change, and now I get a ConditionTimeoutException instead of an NPE, but it still fails maybe 1 in 50 times. - Dan Smith On July 25, 2016, 10:18 p.m., xiaojian zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50420/ > ----------------------------------------------------------- > > (Updated July 25, 2016, 10:18 p.m.) > > > Review request for geode and Dan Smith. > > > Bugs: GEODE-1671 > https://issues.apache.org/jira/browse/GEODE-1671 > > > Repository: geode > > > Description > ------- > > Need to add Awaitility.waitAtMost > > > Diffs > ----- > > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/LuceneTestUtilities.java > da281ff > > Diff: https://reviews.apache.org/r/50420/diff/ > > > Testing > ------- > > > Thanks, > > xiaojian zhou > >
