----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50468/#review143633 -----------------------------------------------------------
Fix it, then Ship it! geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java (lines 1520 - 1521) <https://reviews.apache.org/r/50468/#comment209461> This tag should be deleted from the javadoc for this method - it applies to writeEntryToDisk(). Parameters entry and region aren't listed in the javadoc comment. We should either list them all (preferrable) or none of them. Doesn't change anything functionally, but might help whoever next looks through this code. geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java (lines 1530 - 1531) <https://reviews.apache.org/r/50468/#comment209462> Javadoc comment doesn't list all of the method's parameters - Ken Howe On July 26, 2016, 10:11 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50468/ > ----------------------------------------------------------- > > (Updated July 26, 2016, 10:11 p.m.) > > > Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai > Boorlagadda. > > > Bugs: GEODE-1700 > https://issues.apache.org/jira/browse/GEODE-1700 > > > Repository: geode > > > Description > ------- > > A common method is now used for writing async ops to disk. > The same method is now used for both flushing an item that > has been taken out of the queue and for when the queue is > full causing a sync write to be done. > > Also did a minor refactoring to get rid of the "removed" flag. > > > Diffs > ----- > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java > 698e3bd101ccec92833a1feead0a253ae8ce9bf0 > > Diff: https://reviews.apache.org/r/50468/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Darrel Schneider > >
