----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50572/ -----------------------------------------------------------
Review request for geode, Bruce Schuchardt, Darrel Schneider, Grace Meilen, Jinmei Liao, Kevin Duling, and Swapnil Bawaskar. Bugs: GEODE-1701 https://issues.apache.org/jira/browse/GEODE-1701 Repository: geode Description ------- GEODE-1701: rename GeodePermission as ResourcePermission This is the same change we discussed on dev@geode list. I was preparing this review when I accidentally pushed the change early, so it's already committed to develop (sorry!). If anyone prefers that I back it out until we have a couple positive reviews let me know. Otherwise I'll followup my commit with a new commit to address any issues found during this review. Diffs ----- geode-core/src/main/java/com/gemstone/gemfire/cache/operations/OperationContext.java f4d5280 geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java 19f3325 geode-core/src/main/java/com/gemstone/gemfire/internal/security/shiro/CustomAuthRealm.java c890dc9 geode-core/src/main/java/com/gemstone/gemfire/management/AsyncEventQueueMXBean.java 093bee6 geode-core/src/main/java/com/gemstone/gemfire/management/CacheServerMXBean.java 94dcbbb geode-core/src/main/java/com/gemstone/gemfire/management/DiskStoreMXBean.java 484c43b geode-core/src/main/java/com/gemstone/gemfire/management/DistributedLockServiceMXBean.java 26f785b geode-core/src/main/java/com/gemstone/gemfire/management/DistributedRegionMXBean.java 4e384da geode-core/src/main/java/com/gemstone/gemfire/management/DistributedSystemMXBean.java 2cbb912 geode-core/src/main/java/com/gemstone/gemfire/management/GatewayReceiverMXBean.java 9c7011c geode-core/src/main/java/com/gemstone/gemfire/management/GatewaySenderMXBean.java 429e155 geode-core/src/main/java/com/gemstone/gemfire/management/LocatorMXBean.java c81267c geode-core/src/main/java/com/gemstone/gemfire/management/LockServiceMXBean.java e255915 geode-core/src/main/java/com/gemstone/gemfire/management/ManagerMXBean.java 709b267 geode-core/src/main/java/com/gemstone/gemfire/management/MemberMXBean.java a3b036f geode-core/src/main/java/com/gemstone/gemfire/management/RegionMXBean.java 397b1d9 geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ClientCommands.java 83501ac geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommands.java 900f204 geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java 3d49845 geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/DataCommands.java 89dce97 geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommands.java 131775b geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommands.java a98bf80 geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/DurableClientCommands.java 3f97e5d geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ExportImportSharedConfigurationCommands.java 268a1e4 geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/FunctionCommands.java cb61243 geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommands.java 23d09dd geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/MemberCommands.java c4e1b83 geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommands.java ab5917d geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/PDXCommands.java ae8f36a geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/QueueCommands.java 638e402 geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/RegionCommands.java 9114fc8 geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/StatusCommands.java 4b94813 geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/WanCommands.java 9bd0248 geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/MBeanServerWrapper.java a9b4855 geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/ResourceOperation.java 694ec7d geode-core/src/main/java/org/apache/geode/security/GeodePermission.java 21cec6b geode-core/src/main/java/org/apache/geode/security/ResourcePermission.java PRE-CREATION geode-core/src/main/java/org/apache/geode/security/SecurityManager.java 51a6879 geode-core/src/main/java/org/apache/geode/security/templates/SampleSecurityManager.java 97ebe4f geode-core/src/test/java/com/gemstone/gemfire/internal/cache/extension/mock/MockExtensionCommands.java 8355152 geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/CommandManagerJUnitTest.java ea7f7b9 geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/GfshParserJUnitTest.java 55e6bd7 geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/shell/GfshExecutionStrategyJUnitTest.java fff8890 geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodePermissionJUnitTest.java 104ea5e geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodeSecurityUtilWithIniFileJUnitTest.java ec0d393 geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ResourcePermissionTest.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java 875aeef geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/excludedClasses.txt 10701fe geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/cli/LuceneIndexCommands.java ad00a8b geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/management/LuceneServiceMXBean.java b307645 Diff: https://reviews.apache.org/r/50572/diff/ Testing ------- precheckin Thanks, Kirk Lund