----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50607/#review144124 -----------------------------------------------------------
Ship it! Ship It! - Bruce Schuchardt On July 29, 2016, 4:58 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50607/ > ----------------------------------------------------------- > > (Updated July 29, 2016, 4:58 p.m.) > > > Review request for geode, anilkumar gingade, Bruce Schuchardt, and Dan Smith. > > > Repository: geode > > > Description > ------- > > This test verifies perf of durable client -queue with overflow. In case of > overflow client queue uses LIFO policy. Because of that we put new entry on > disk first. But, after putting that entry into queue that thread needs to > update Cq stats, which causes that thread to fetch that value again from > disk. that hurts performance. we should be updating any(all) client stats > before putting that value into disk. > > Using "hw.getClientUpdateMessage()" to update the stats.. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueue.java > c5746ed > > Diff: https://reviews.apache.org/r/50607/diff/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
