----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50798/#review144774 -----------------------------------------------------------
Ship it! Ship It! - Hitesh Khamesra On Aug. 4, 2016, 3:44 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50798/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2016, 3:44 p.m.) > > > Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer. > > > Bugs: GEODE-1727 > https://issues.apache.org/jira/browse/GEODE-1727 > > > Repository: geode > > > Description > ------- > > We added a fix for shutting down the transport protocol's Timer but it was > being done after stopping the protocol. JGroups shutdown code has always > tended toward nulling out instance variables for some reason and this lead to > an NPE when a timer task fired and tried to retransmit a message using the > null TP.bundler variable. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/Transport.java > 2ba319de69df0e82f996c212adbf6ae200e36fe8 > > Diff: https://reviews.apache.org/r/50798/diff/ > > > Testing > ------- > > > Thanks, > > Bruce Schuchardt > >
