----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50818/ -----------------------------------------------------------
Review request for geode and Jason Huynh. Repository: geode Description ------- The geode session filter is being applied to all requests. Because of that, all request objects should already be wrapped in a RequestWrapper. By adding these dispatcher elements to the filter, the filter was being applied multiple times to the request when a request is forwarded or included using the RequestDipatcher. That is unnecessary, and problematic if we can't determine that the request has already been wrapped. GEODE-1728: Recursively checking for wrapped http sessions Our check for wrapped http sessions in the session caching module was not working if a request was wrapped by our module and then by a third party filter that also wrapped the request. Diffs ----- extensions/geode-modules-session/build.gradle 4045a69fe1eb0d287a16954cf4fdf4ed4b18a6e0 extensions/geode-modules-session/src/main/java/com/gemstone/gemfire/modules/session/filter/SessionCachingFilter.java 7abc25370660281741423aed87326cf45e4292ad extensions/geode-modules-session/src/main/java/com/gemstone/gemfire/modules/session/installer/Installer.java 7ba5b34abc86522df94de849777b5ae2a8731221 extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/installer/InstallerJUnitTest.java PRE-CREATION extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/internal/filter/CommonTests.java c341c6f167dc5d5d5c18c7fd7976076ec43381f7 extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java da5673523f8c359bdcfa3e36513e3e4355667b5b extensions/geode-modules-session/src/test/resources/com/gemstone/gemfire/modules/session/installer/InstallerJUnitTest.web.xml PRE-CREATION extensions/geode-modules-session/src/test/resources/com/gemstone/gemfire/modules/session/installer/InstallerJUnitTest.web.xml.expected PRE-CREATION Diff: https://reviews.apache.org/r/50818/diff/ Testing ------- Thanks, Dan Smith
