----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51018/#review145677 -----------------------------------------------------------
Ship it! Ship It! - Scott Jewell On Aug. 11, 2016, 11:15 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51018/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2016, 11:15 p.m.) > > > Review request for geode, Eric Shu, Scott Jewell, and Ken Howe. > > > Bugs: GEODE-1714 > https://issues.apache.org/jira/browse/GEODE-1714 > > > Repository: geode > > > Description > ------- > > entriesInVM no longer counts entries that have no value in the VM. > Before it was counting invalid entries as being inVM. > Also fixed some code paths that were not updating the PR stats which led to > dataStoreEntriesInUse not being consistent with CachePerfStats entries. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractLRURegionMap.java > c9b3038f79ae917b04316e89017c84daa4a8d76a > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java > f3cb3d654087c797de430f448348c3ba66846ac4 > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java > 98ee7292a3ae75d8d5bc26a7af3d64f34cea55e8 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java > 46ccd47e96e75a8c4c6f3075b65a2d2447043213 > > geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskRegionDUnitTest.java > a43950edde101c8c28c7773571f6e74b5dfad5fd > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/DiskRegRecoveryJUnitTest.java > 792f07eb1a8af4a93eb67ad15378fdbf350d218e > > Diff: https://reviews.apache.org/r/51018/diff/ > > > Testing > ------- > > precheckin > Also run a bunch of hydra tests that had been failing > > > Thanks, > > Darrel Schneider > >
