----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51098/#review145878 -----------------------------------------------------------
Ship it! Ship It! - Kevin Duling On Aug. 15, 2016, 6:39 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51098/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2016, 6:39 p.m.) > > > Review request for geode, Darrel Schneider, Kevin Duling, Lynn > Hughes-Godfrey, Lynn Gallinat, and Dan Smith. > > > Bugs: GEODE-1781 > https://issues.apache.org/jira/browse/GEODE-1781 > > > Repository: geode > > > Description > ------- > > GEODE-1781: repackage internal statistics classes and refactor statistics > tests > > * move internal statistics classes and tests into > com.gemstone.gemfire.internal.statistics pkg > * modify tests to include integration and distributed in names > * modify tests to use TemporaryFolder and TestName rules > * remove unused classes and dead code from statistics tests > > > Diffs > ----- > > > extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/session/catalina/internal/DeltaSessionStatistics.java > 2d59103 > > extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/util/ModuleStatistics.java > 82e882c > geode-core/src/main/java/com/gemstone/gemfire/StatisticsFactory.java > 3ef5ba5 > geode-core/src/main/java/com/gemstone/gemfire/StatisticsTypeFactory.java > 9b6c546 > > geode-core/src/main/java/com/gemstone/gemfire/admin/internal/MemberHealthEvaluator.java > d0710ca > > geode-core/src/main/java/com/gemstone/gemfire/cache/asyncqueue/internal/AsyncEventQueueStats.java > 8d541a3 > > geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ConnectionStats.java > 4bd4439 > > geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/EndpointManagerImpl.java > d155602 > > geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/PoolImpl.java > b26d76b > > geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/CqQueryVsdStats.java > e9d30d5 > > geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/IndexStats.java > 77941b6 > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionStats.java > c4803ab > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java > 1ea5611 > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/LocatorStats.java > f59ed84 > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/locks/DLockStats.java > 9a61c10 > > geode-core/src/main/java/com/gemstone/gemfire/internal/AbstractStatisticsFactory.java > 972e670e > geode-core/src/main/java/com/gemstone/gemfire/internal/ArchiveSplitter.java > 28b9dd7 > > geode-core/src/main/java/com/gemstone/gemfire/internal/DummyStatisticsFactory.java > 9d280eb > > geode-core/src/main/java/com/gemstone/gemfire/internal/DummyStatisticsImpl.java > aa8da50 > > geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireStatSampler.java > 1eb35d0 > geode-core/src/main/java/com/gemstone/gemfire/internal/HostStatHelper.java > 7ff0b1b > geode-core/src/main/java/com/gemstone/gemfire/internal/HostStatSampler.java > ff9d2fb > > geode-core/src/main/java/com/gemstone/gemfire/internal/LinuxProcFsStatistics.java > 3070287 > > geode-core/src/main/java/com/gemstone/gemfire/internal/LinuxProcessStats.java > 05bc284 > > geode-core/src/main/java/com/gemstone/gemfire/internal/LinuxSystemStats.java > 22158da > > geode-core/src/main/java/com/gemstone/gemfire/internal/LocalStatListener.java > c46bc2f > > geode-core/src/main/java/com/gemstone/gemfire/internal/LocalStatisticsFactory.java > 6f8315a > > geode-core/src/main/java/com/gemstone/gemfire/internal/LocalStatisticsImpl.java > cf59e1f > geode-core/src/main/java/com/gemstone/gemfire/internal/OSXProcessStats.java > 0706c7b > geode-core/src/main/java/com/gemstone/gemfire/internal/OSXSystemStats.java > 8d440ca > > geode-core/src/main/java/com/gemstone/gemfire/internal/OsStatisticsFactory.java > 7dac90e > geode-core/src/main/java/com/gemstone/gemfire/internal/ProcessStats.java > c80e340 > > geode-core/src/main/java/com/gemstone/gemfire/internal/SimpleStatSampler.java > b3cc56b > > geode-core/src/main/java/com/gemstone/gemfire/internal/SolarisProcessStats.java > d07d398 > > geode-core/src/main/java/com/gemstone/gemfire/internal/SolarisSystemStats.java > 9f56943 > > geode-core/src/main/java/com/gemstone/gemfire/internal/StatArchiveFormat.java > d1e67f9 > > geode-core/src/main/java/com/gemstone/gemfire/internal/StatArchiveReader.java > 0947b0d > > geode-core/src/main/java/com/gemstone/gemfire/internal/StatArchiveWriter.java > fcf645d > > geode-core/src/main/java/com/gemstone/gemfire/internal/StatSamplerStats.java > c3d556f > > geode-core/src/main/java/com/gemstone/gemfire/internal/StatisticDescriptorImpl.java > 2f407ba > geode-core/src/main/java/com/gemstone/gemfire/internal/StatisticsImpl.java > 04bfc01 > > geode-core/src/main/java/com/gemstone/gemfire/internal/StatisticsManager.java > c33d163 > > geode-core/src/main/java/com/gemstone/gemfire/internal/StatisticsTypeFactoryImpl.java > e4688d5 > > geode-core/src/main/java/com/gemstone/gemfire/internal/StatisticsTypeImpl.java > ccd4d6c > > geode-core/src/main/java/com/gemstone/gemfire/internal/StatisticsTypeXml.java > 0ce0422 > geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java > cc03ad6 > geode-core/src/main/java/com/gemstone/gemfire/internal/VMStats.java d7dde46 > geode-core/src/main/java/com/gemstone/gemfire/internal/VMStatsContract.java > 238cf86 > > geode-core/src/main/java/com/gemstone/gemfire/internal/VMStatsContractFactory.java > ff84b0e > > geode-core/src/main/java/com/gemstone/gemfire/internal/WindowsProcessStats.java > a671717 > > geode-core/src/main/java/com/gemstone/gemfire/internal/WindowsSystemStats.java > 1325fcc > > geode-core/src/main/java/com/gemstone/gemfire/internal/admin/remote/AddStatListenerResponse.java > 7ea19f5 > > geode-core/src/main/java/com/gemstone/gemfire/internal/admin/remote/AdminConsoleDisconnectMessage.java > 2f8d336 > > geode-core/src/main/java/com/gemstone/gemfire/internal/admin/remote/CancelStatListenerResponse.java > d338b70 > > geode-core/src/main/java/com/gemstone/gemfire/internal/admin/remote/RemoteStat.java > cdc2b88 > > geode-core/src/main/java/com/gemstone/gemfire/internal/admin/remote/package.html > a2fef69 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CachePerfStats.java > 72a850d > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskDirectoryStats.java > 21a7b26 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskRegionStats.java > ae9b0a9 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskStoreStats.java > db505b9 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegionStats.java > 04d432f > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PoolStats.java > 2161de7 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/control/HeapMemoryMonitor.java > bc83335 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/control/ResourceManagerStats.java > d54e7c4 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceStats.java > e62d800 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/FunctionStats.java > 0e7687a > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueueStats.java > e7b74d1 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/lru/HeapLRUCapacityController.java > 7bf2d1f > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/lru/LRUCapacityController.java > 0e5afab > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/lru/MemLRUCapacityController.java > d1634b4 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java > edf3a94 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifierStats.java > afc4235 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientProxyStats.java > cf69d90 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientUpdater.java > 391c3e6 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheServerStats.java > 626e075 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderStats.java > 15a6dee > > geode-core/src/main/java/com/gemstone/gemfire/internal/concurrent/Atomics.java > 8940a69 > > geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStorage.java > bc7fb6a > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/AbstractStatisticsFactory.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/ArchiveSplitter.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/CallbackSampler.java > 4bc3009 > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/DummyStatisticsFactory.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/DummyStatisticsImpl.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/GemFireStatSampler.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/HostStatHelper.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/HostStatSampler.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/IgnoreResourceException.java > 2abf4b8 > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/LocalStatListener.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/LocalStatisticsFactory.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/LocalStatisticsImpl.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/ResourceInstance.java > 0de95e2 > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/ResourceType.java > d401969 > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/SimpleStatSampler.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/StatArchiveDescriptor.java > 6d6624a > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/StatArchiveFormat.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/StatArchiveHandler.java > e686ad6 > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/StatArchiveHandlerConfig.java > dd46013 > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/StatArchiveReader.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/StatArchiveWriter.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/StatSamplerStats.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/StatisticDescriptorImpl.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/StatisticsImpl.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/StatisticsManager.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/StatisticsTypeFactoryImpl.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/StatisticsTypeImpl.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/StatisticsTypeXml.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/VMStats.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/VMStatsContract.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/VMStatsContractFactory.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/ValueMonitor.java > 211719f > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/package.html > 8875df2 > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/platform/LinuxProcFsStatistics.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/platform/LinuxProcessStats.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/platform/LinuxSystemStats.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/platform/OSXProcessStats.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/platform/OSXSystemStats.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/platform/OsStatisticsFactory.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/platform/ProcessStats.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/platform/SolarisProcessStats.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/platform/SolarisSystemStats.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/platform/WindowsProcessStats.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/platform/WindowsSystemStats.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/stats50/Atomic50StatisticsImpl.java > f374394 > > geode-core/src/main/java/com/gemstone/gemfire/internal/stats50/VMStats50.java > 6f2eea6 > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/beans/MemberMBeanBridge.java > 89cc4f0 > geode-core/src/test/java/com/gemstone/gemfire/GemFireTestCase.java 337f971 > geode-core/src/test/java/com/gemstone/gemfire/Invariant.java 1c712d2 > geode-core/src/test/java/com/gemstone/gemfire/InvariantResult.java 272e026 > geode-core/src/test/java/com/gemstone/gemfire/LocalStatisticsJUnitTest.java > ab5b8e1 > geode-core/src/test/java/com/gemstone/gemfire/StatisticsTestCase.java > 03b5e16 > geode-core/src/test/java/com/gemstone/gemfire/StatisticsTypeJUnitTest.java > 1d221a2 > > geode-core/src/test/java/com/gemstone/gemfire/admin/internal/MemberHealthEvaluatorJUnitTest.java > 6791dcc > > geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsDUnitTest.java > baad698 > > geode-core/src/test/java/com/gemstone/gemfire/codeAnalysis/decode/CompiledClass.java > 9e03956 > > geode-core/src/test/java/com/gemstone/gemfire/internal/DataSerializableJUnitTest.java > 273d3c6 > > geode-core/src/test/java/com/gemstone/gemfire/internal/GemFireStatSamplerJUnitTest.java > ef07633 > > geode-core/src/test/java/com/gemstone/gemfire/internal/LocalStatisticsImplJUnitTest.java > a9b1ec7 > > geode-core/src/test/java/com/gemstone/gemfire/internal/SimpleStatSamplerJUnitTest.java > 5d7c9f4 > > geode-core/src/test/java/com/gemstone/gemfire/internal/StatArchiveWriterReaderJUnitTest.java > ea9ff4b > > geode-core/src/test/java/com/gemstone/gemfire/internal/StatSamplerJUnitTest.java > e16eeaf > > geode-core/src/test/java/com/gemstone/gemfire/internal/StatSamplerTestCase.java > 819a79c > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/lru/LRUClockJUnitTest.java > 16b7ac5 > > geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStorageJUnitTest.java > 93bef98 > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/CallbackSamplerJUnitTest.java > 47bfc58 > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/CallbackSamplerTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/DistributedSystemStatisticsIntegrationTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/DistributedSystemStatisticsTypeIntegrationTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/GemFireStatSamplerIntegrationTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/SampleCollectorJUnitTest.java > 1babbc1 > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/SampleCollectorTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/SimpleStatSamplerIntegrationTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatArchiveWriterReaderIntegrationTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatMonitorHandlerJUnitTest.java > bcb7497 > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatMonitorHandlerTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatSamplerIntegrationTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatSamplerTestCase.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatisticsDUnitTest.java > 1e7a4e4 > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatisticsDistributedTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatisticsImplTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatisticsMonitorJUnitTest.java > b995451 > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatisticsMonitorTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/TestStatArchiveWriter.java > 81d963e > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/TestStatisticsManager.java > fbb3dce > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/TestStatisticsSampler.java > 0905167 > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/ValueMonitorIntegrationTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/ValueMonitorJUnitTest.java > b671250 > > geode-core/src/test/java/com/gemstone/gemfire/internal/stats50/AtomicStatsJUnitTest.java > 1fc1d23 > > geode-core/src/test/java/com/gemstone/gemfire/management/bean/stats/MemberLevelStatsJUnitTest.java > dcbbaca > > geode-core/src/test/resources/com/gemstone/gemfire/internal/StatArchiveWriterReaderJUnitTest_testWriteAfterSamplingBegins_expected.gfs > 7fc826591e7f7c864ce914cd13c423ae1f67fde5 > > geode-core/src/test/resources/com/gemstone/gemfire/internal/StatArchiveWriterReaderJUnitTest_testWriteWhenSamplingBegins_expected.gfs > 15a01b03a14f19a8ba24470da7963e4433e29c7b > > geode-core/src/test/resources/com/gemstone/gemfire/internal/statistics/StatArchiveWriterReaderJUnitTest_testWriteAfterSamplingBegins_expected.gfs > PRE-CREATION > > geode-core/src/test/resources/com/gemstone/gemfire/internal/statistics/StatArchiveWriterReaderJUnitTest_testWriteWhenSamplingBegins_expected.gfs > PRE-CREATION > > geode-cq/src/main/java/com/gemstone/gemfire/cache/query/internal/cq/CqServiceVsdStats.java > 3327909 > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexStats.java > 4f89fa7 > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemStats.java > ee66850 > > geode-rebalancer/src/test/java/com/gemstone/gemfire/cache/util/AutoBalancerIntegrationJUnitTest.java > 5ab8d0e > > Diff: https://reviews.apache.org/r/51098/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Kirk Lund > >
