----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51118/#review145919 -----------------------------------------------------------
Ship it! Ship It! - Eric Shu On Aug. 15, 2016, 11:29 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51118/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2016, 11:29 p.m.) > > > Review request for geode, Eric Shu, Scott Jewell, and Ken Howe. > > > Bugs: GEODE-1691 > https://issues.apache.org/jira/browse/GEODE-1691 > > > Repository: geode > > > Description > ------- > > The external methods on EntryEvent and SerializedCacheValue that can access > an off-heap value now do so while holding a lock that is also used by the > internal code that releases the off-heap references. > A unit test has been added that confirms that the external read methods will > all wait if release is in progress. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java > f559e2a2ec8d72d7d6eec5a86f24f45d6ab193b0 > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/EntryEventImplTest.java > 265795f3f3da2c64d713da7cc240b2ad7ca69c0b > > Diff: https://reviews.apache.org/r/51118/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Darrel Schneider > >
