----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51184/ -----------------------------------------------------------
Review request for geode and Dan Smith. Repository: geode Description ------- Fix possible npe with manager being null Fix ClassCastException with Client/Server expiration Added new client server tests. Refactored peer to peer tests to have a common base with client server. This causes the tests to run a bit longer (due to extending JUnit4DistributedTestCase needing @Before and @After. This requires the server and tomcat server to be restarted for each test due to the framework shutting down the server every test) Diffs ----- extensions/geode-modules-tomcat8/src/main/java/com/gemstone/gemfire/modules/session/catalina/DeltaSession8.java aa07b5b extensions/geode-modules-tomcat8/src/test/java/com/gemstone/gemfire/modules/session/TestSessionsTomcat8Base.java 76b301d extensions/geode-modules-tomcat8/src/test/java/com/gemstone/gemfire/modules/session/Tomcat8SessionsClientServerJUnitTest.java PRE-CREATION extensions/geode-modules-tomcat8/src/test/java/com/gemstone/gemfire/modules/session/Tomcat8SessionsJUnitTest.java df65690 extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/session/bootstrap/AbstractCache.java c14f829 extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/session/bootstrap/ClientServerCache.java f8cff16 extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/session/bootstrap/PeerToPeerCache.java b0b3b4a extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/session/catalina/AbstractCacheLifecycleListener.java 1019ddc extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/session/catalina/DeltaSession.java ff7133d extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/session/catalina/DeltaSessionInterface.java 1d3d1f7 extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/session/catalina/callback/SessionExpirationCacheListener.java 5893c95 geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/examples/RuleAndClassRuleTest.java 4e69ec3 Diff: https://reviews.apache.org/r/51184/diff/ Testing ------- Thanks, Jason Huynh
