----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51208/#review146087 -----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ClientMetadataService.java (line 625) <https://reviews.apache.org/r/51208/#comment212466> I'm missing a statistics update here - I'll add it. - Bruce Schuchardt On Aug. 18, 2016, 3:54 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51208/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2016, 3:54 p.m.) > > > Review request for geode, Hitesh Khamesra and Udo Kohlmeyer. > > > Bugs: GEODE-1761 > https://issues.apache.org/jira/browse/GEODE-1761 > > > Repository: geode > > > Description > ------- > > Servers will send a refresh hint to clients if they detect that a request had > to be send to a different server who owned the primary bucket affected by the > operation. Clients should always refresh when this happens unless they have > connection-pool size constraints that force them to use non-optimal servers. > > Client-side operation classes have been modified to initiate the refresh. > I've added code in the meta-data service class to avoid performing multiple > concurrent refreshes on the same region. > > On the server-side I've cleaned up some of the network-hop detection code to > stop using hard-coded integers and to consolidate some of the code that > resets the ThreadLocals being used to record network-hops detected. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/AbstractOp.java > 1eb0dbdddd2d24d01b77fea3315a6ce26b6f959c > > geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ClientMetadataService.java > 6e255c478e1d87bdf58d52934647a4acea2c655c > > geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/DestroyOp.java > e8ce1a7f88ed1bb7a8d7235f69c018611358364a > > geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/GetClientPRMetaDataOp.java > 9a467f7793a7d20c8f3a3ae6945261054f79d079 > > geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/GetOp.java > 6864306e0884d9b531660e78834a6bc007ece884 > > geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/PutAllOp.java > 16104563be74f45074faae62042d68d5e44dc0e1 > > geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/PutOp.java > 072ec4e1ddcf79c1a5e5030e6e94be780f98791a > > geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/RemoveAllOp.java > 1ab1ed31b9033bb89ba08e15592563dd243c0354 > > geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/SingleHopOperationCallable.java > 6047a501134734c3e2ef070777b0fdbf4f445c91 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java > 9ac95a1f9c0ab880d6cab8a350bd9c4842797d5d > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/BaseCommand.java > f3485d255cb641c926bc8f0333426ccc41b3ae78 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Message.java > 4947e202296897b01efcb75075f5056f2442bba0 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Destroy.java > bc47e2a3ee93427dc2f251c3298c38dfdf5a54cb > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Destroy65.java > a571f713d4232ff94085f32c5e9a10ac35b3e98b > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Destroy70.java > 82d9c1a0f65dd2e00a1454cff50d680d94d1fe11 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Get70.java > f5d9937ec06a85eacc3aa8f473b7824b51d3fd6e > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Invalidate.java > 166b11a3d385a0f8d21f66158603788746f17256 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Invalidate70.java > 6200438428a67d49c005cddc25caeacbd81c8e14 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Put61.java > 4529b2d035b8ff50e75fc46fc04fe365b345188a > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Put65.java > 48d923cce194e7ae7829401b910300a809bcbf38 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Put70.java > af16bed71143beb410dd84018cc15a9ebec08ef0 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/PutAll.java > 955677feb419719db8a413be088d9a7cac5e6cf1 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/PutAll70.java > 4e6e167ffb5183d9cb4b0d1226318e473d48cb90 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/PutAll80.java > 78f5612de5099b172a470939db0eb390c019514c > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/RemoveAll.java > 474d942ed93737a3b81ff3e638669b65b92355e0 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Request.java > c84e18954a00cb3ce06bc938411fb0aa66ed0a4f > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionSingleHopDUnitTest.java > 8c934d8417b1604c174900f8a5a7a6e0da016618 > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/SingleHopStatsDUnitTest.java > e611086d9fadadb17cf606b1efc0e78bd7faf9fe > > Diff: https://reviews.apache.org/r/51208/diff/ > > > Testing > ------- > > > Thanks, > > Bruce Schuchardt > >
