----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51249/ -----------------------------------------------------------
Review request for geode, Hitesh Khamesra and Udo Kohlmeyer. Bugs: GEODE-1800 https://issues.apache.org/jira/browse/GEODE-1800 Repository: geode Description ------- The faulty methods in StoppableCondition have been removed. I considered removing StoppableCondition entirely and just using a Condition on the lock wrapped by the Stoppable lock class but doing so would require additional work to make the CancelCriterion available to the code that uses these StoppableConditions, so other than removing the methods I've left the class alone. Diffs ----- geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 1ea5611fcc197a04dbd35f6386e66fc2f0ac997d geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/locks/GrantorRequestProcessor.java e22a8c06ce73d5cc5d5aa08a57eb8aac66cb6965 geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueue.java 6ac56ffa89b6cde47319ac9e9bb99e234b8d485a geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java 1b5c11f3d00a256df8128eb1cd9b80b2989d990a geode-core/src/main/java/com/gemstone/gemfire/internal/util/concurrent/StoppableCondition.java 5c33498ab3c5de6ae1843449e4c44f3d8eabd2d0 Diff: https://reviews.apache.org/r/51249/diff/ Testing ------- precheckin Thanks, Bruce Schuchardt