----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51305/ -----------------------------------------------------------
Review request for geode and Barry Oglesby. Repository: geode Description ------- While exchanging locators, DistributionLocatorID will be constructed using hostNameforClients. It looks like this was happening if an embedded locator was started using the start-locator distributed system property, but not for any other case. Adding a test that we actually send the hostname for clients to remote locators. Diffs ----- geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalLocator.java 46d96108cb4d33cbe6fc18ee08464d4430a70d03 geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/WanLocatorDiscoverer.java 450d3a129fe3d758da016544195df650ba236d24 geode-core/src/main/java/com/gemstone/gemfire/internal/admin/remote/DistributionLocatorId.java 1459d89092039b83402eb7253dcbfcff1548708a geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java 443fe7866bd537a037f552f0586a67f707117fd6 geode-wan/src/main/java/com/gemstone/gemfire/cache/client/internal/locator/wan/LocatorDiscovery.java 0fd206e25e7a5bad43aeb25d46b005b22289eab5 geode-wan/src/main/java/com/gemstone/gemfire/cache/client/internal/locator/wan/WanLocatorDiscovererImpl.java b6a007041768a8d85022bdb9c0b45f0f80418fd7 geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java fd2c0b5aa0115cd0f666240f1923369c29ae67f4 geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java fc16571284be22007683000d093f2921aa994967 Diff: https://reviews.apache.org/r/51305/diff/ Testing ------- Thanks, Dan Smith