----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51340/#review146549 -----------------------------------------------------------
Wouldn't it be better to just set a VmKind in the ID created by JGroupsMessenger if it can't find a corresponding ID in the membership views? Either that or get rid of the assertion in InternalDistributedMember. Adding an extra byte to every message transmitted seems like a big price to pay just to avoid this assertion failure. - Bruce Schuchardt On Aug. 23, 2016, 4:25 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51340/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2016, 4:25 p.m.) > > > Review request for geode, Bruce Schuchardt and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > Fix for GEM-946 > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMember.java > b7754ce > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java > f43c98d > > Diff: https://reviews.apache.org/r/51340/diff/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
