----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51349/#review146793 -----------------------------------------------------------
Ship it! Ship It! - Kirk Lund On Aug. 23, 2016, 10:17 p.m., Swapnil Bawaskar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51349/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2016, 10:17 p.m.) > > > Review request for geode and Kirk Lund. > > > Repository: geode > > > Description > ------- > > changed the Principal to be an Object to be consistent with how > other projects incuding spring-security and Apache shiro use Principal. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/security/shiro/CustomAuthRealm.java > b9dd8c00dae296d98d6d88bad0f938dffa89885c > geode-core/src/main/java/org/apache/geode/security/SecurityManager.java > 9db4734f14888b7b6c0b54c672d4f0644a5fffa7 > > geode-core/src/main/java/org/apache/geode/security/templates/SampleSecurityManager.java > 5948527b3bbcdebf2ece24125593e338e2cd13e0 > > geode-core/src/test/java/com/gemstone/gemfire/security/SpySecurityManager.java > 31ebde564ba03dfcaa68720c5c640055e832a7c4 > > Diff: https://reviews.apache.org/r/51349/diff/ > > > Testing > ------- > > > Thanks, > > Swapnil Bawaskar > >