----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51510/#review147315 -----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java (line 6094) <https://reviews.apache.org/r/51510/#comment214433> setting invokeCallbacks to true if newValue is not a tombstone makes sense to me. But why do you also say == null? Since null != TOMBSTONE you don't need this null check. I also find that old comment "put() is creating a tombstone" confusing. Something like this would make more sense to me "invoke callbacks if not creating a tombstone". - Darrel Schneider On Aug. 29, 2016, 5:43 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51510/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2016, 5:43 p.m.) > > > Review request for geode, Bruce Schuchardt and Darrel Schneider. > > > Repository: geode > > > Description > ------- > > In LocalRegion.basicPutPart2, check for a TOMBSTONE using > EntryEvent.getNewValue. Previously we were checking the > RegionEntry.isTombstone, but in the case of a PROXY region, the > RegionEntry is marker that does not set isTombstone to true. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java > 46ccd47e96e75a8c4c6f3075b65a2d2447043213 > > geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientServerCCEDUnitTest.java > 957dcc05d9d6481b95784a03ee6f2c52d5b937e5 > > Diff: https://reviews.apache.org/r/51510/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
