----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51545/#review147385 -----------------------------------------------------------
Ship it! Ship It! - Anthony Baker On Aug. 30, 2016, 11:41 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51545/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2016, 11:41 p.m.) > > > Review request for geode, Anthony Baker and Scott Jewell. > > > Repository: geode > > > Description > ------- > > With the eclipse compiler, AsyncEventListenerDUnitTest was generating a > compilation error about a deserializeLambda method being to large. This > doesn't seem to be a real issue because the javac doesn't have > the same problem. However, by refactoring the test slightly I was able > to make this error go away. > > Changed the eclipse classpath to include the generated-resources > directories. These directories contain files like > GemFireVersion.properties that need to be included on the classpath, but > we were filtering them out. > > > Diffs > ----- > > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerDUnitTest.java > 4c78bdc0cc43582d3b064e02e01f10c8c53eee81 > gradle/ide.gradle d07ad0bac1444e76f7d518e4ab79958cc2f61b69 > > Diff: https://reviews.apache.org/r/51545/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
