----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51567/#review147508 -----------------------------------------------------------
Ship it! Ship It! - Dan Smith On Aug. 31, 2016, 11:49 p.m., xiaojian zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51567/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2016, 11:49 p.m.) > > > Review request for geode and Dan Smith. > > > Bugs: GEODE-1833 > https://issues.apache.org/jira/browse/GEODE-1833 > > > Repository: geode > > > Description > ------- > > The code called sender.getServerLocation() every time. > > If we only check if it's null once, then we should save the reference, > otherwise, we have to check the null after each call of > sender.getServerLocation(). > > > Diffs > ----- > > > geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java > 2625ad2 > > Diff: https://reviews.apache.org/r/51567/diff/ > > > Testing > ------- > > > Thanks, > > xiaojian zhou > >
