----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51585/#review147613 -----------------------------------------------------------
I think the ID needs to include something indicating that this profile is for lucene, rather than some other cache service. Maybe the fully qualified name of the class? I don't think adding the region really makes a difference, because the profile is already region specific. - Dan Smith On Sept. 1, 2016, 10:04 p.m., xiaojian zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51585/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2016, 10:04 p.m.) > > > Review request for geode and Dan Smith. > > > Bugs: GEODE-11 > https://issues.apache.org/jira/browse/GEODE-11 > > > Repository: geode > > > Description > ------- > > Should return the internal unique name of the index for each lucene index. > > > Diffs > ----- > > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexCreationProfile.java > 720d20d > > Diff: https://reviews.apache.org/r/51585/diff/ > > > Testing > ------- > > geode-lucene:precheckin > > > Thanks, > > xiaojian zhou > >
