----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51612/#review147677 -----------------------------------------------------------
geode-core/src/test/java/com/gemstone/gemfire/management/ConnectToLocatorSSLDUnitTest.java (line 56) <https://reviews.apache.org/r/51612/#comment214889> Change this to @Rule so each Test method gets its own TemporaryFolder. Change to our own custom rule SerializableTemporaryFolder (all dunit VMs can share this). @Rule public SerializableTemporaryFolder folder = new SerializableTemporaryFolder(); geode-core/src/test/java/com/gemstone/gemfire/management/ConnectToLocatorSSLDUnitTest.java (line 111) <https://reviews.apache.org/r/51612/#comment214887> Move the locator.log to temporaryFolder: Locator.startLocatorAndDS(locatorPort, new File(temporaryFolder.getRoot(), "locator.log"), props); geode-core/src/test/java/com/gemstone/gemfire/management/ConnectToLocatorSSLDUnitTest.java (line 119) <https://reviews.apache.org/r/51612/#comment214892> Don't forget to unset this in after(). DUnit is reusing the VMs for 30 dunit test cases. CliUtil.isGfshVM = false; geode-core/src/test/java/com/gemstone/gemfire/management/ConnectToLocatorSSLDUnitTest.java (line 121) <https://reviews.apache.org/r/51612/#comment214888> Move gfsh_files to temporaryFolder: HeadlessGfsh gfsh = new HeadlessGfsh(shellId, 30, temporaryFolder.newFolder("gfsh_files").getCanonicalPath()); - Kirk Lund On Sept. 2, 2016, 5:46 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51612/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2016, 5:46 p.m.) > > > Review request for geode, Bruce Schuchardt, Kevin Duling, Kirk Lund, and Udo > Kohlmeyer. > > > Repository: geode > > > Description > ------- > > GEODE-1834: initilize the socketcreator with the correct ssl settings > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/JmxManagerLocatorRequest.java > 861f51d4e0077440ab3128e6053c389cecfd9bb8 > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommands.java > 09a25a67d748524cbbc19099c453d045b415ce5c > > geode-core/src/test/java/com/gemstone/gemfire/management/ConnectToLocatorSSLDUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/51612/diff/ > > > Testing > ------- > > the newly added tests to cover both cluster-ssl-* and jmx-ssl-* settings. > This would test for both GEM-877 and GEM-626 > > > Thanks, > > Jinmei Liao > >
