----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51741/#review148360 -----------------------------------------------------------
gradle.properties (line 32) <https://reviews.apache.org/r/51741/#comment215818> Do we want to remove '-SNAPSHOT' while on the develop branch? This will cause issues with the nightly upload. I would expect this to change on the release branch. gradle.properties (line 51) <https://reviews.apache.org/r/51741/#comment215820> I agree with Dan. I don't think we want this disabled by default as artifacts need to be signed to be uploaded to Apache repositories - Mark Bretl On Sept. 8, 2016, 12:35 p.m., Jens Deppe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51741/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2016, 12:35 p.m.) > > > Review request for geode, Anthony Baker and Dan Smith. > > > Repository: geode > > > Description > ------- > > This also disables default archive signing which requires GPG keys > > > Diffs > ----- > > build.gradle e112eb77847371f730ba72febfa350bfe9466832 > gradle.properties 06855c7a3782cb83cce9731460d3197749de42f3 > gradle/publish.gradle 2258da6537b69afad0c3188d06f91da9fd8c08c3 > > Diff: https://reviews.apache.org/r/51741/diff/ > > > Testing > ------- > > Local building. The changes come into effect when using 'uploadArchives'. > > > Thanks, > > Jens Deppe > >
