----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51923/#review149104 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java <https://reviews.apache.org/r/51923/#comment216618> Why is this deleted? This is for ssl-enabled-components (Udo's work) and has nothing to do with security-enabled-components aka authentication&authorization (A&A). After Udo's latest commit, we probably need to change his code to use SSLSecurableComponents or SSLSecurableChannels and then change our code to have its own separate SecurableComponents with a different list of constants (depending on what Swapnil's requirements are). geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java (line 104) <https://reviews.apache.org/r/51923/#comment216620> This is broken javadoc that generates warnings during gradle javadoc task. You should delete the @param and @return unless you want to actually write out real values for them. geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java (line 106) <https://reviews.apache.org/r/51923/#comment216621> Typo: secuirty - Kirk Lund On Sept. 15, 2016, 6:14 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51923/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2016, 6:14 p.m.) > > > Review request for geode, Jared Stewart, Kevin Duling, Kirk Lund, and Swapnil > Bawaskar. > > > Repository: geode > > > Description > ------- > > GEODE-1883: making AuthInit optional when starting a server/client > > When starting a server trying to connect to a locator, customer should not > have to implement an AuthInit object, they can just put > security-username/security-password in their properties file. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java > d843792168e91b39b686c84de66b0087c1ae65b4 > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java > 68ec0c0041f204775541db396022a1df14c868fe > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/HandShake.java > 00372aebc8d72376ff6613c13637faeaac8d1523 > > geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java > 7380c9a0cb7382f8a2758acc1018fd793ce815df > geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java > 9123ec4ac00eb2fe5f7d980e78c06c6fe6bcd767 > > geode-core/src/test/java/org/apache/geode/security/PDXGfshPostProcessorOnRemoteServerTest.java > 870ff91ab1a3d3537754268f6e2f2c33f24141b7 > > Diff: https://reviews.apache.org/r/51923/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Jinmei Liao > >
