Here are a few more changes that are needed: 1) Update IDE formatters:
./etc/eclipseOrganizeImports.importorder ./etc/intellijIdeaCodeStyle.xml 2) Javadocs geode-core/src/main/java/org/apache/geode/distributed/internal/package.html geode-core/src/main/java/org/apache/geode/internal/cache/properties.html geode-core/src/main/java/org/apache/geode/internal/cache/DistPeerTXStateStub.java geode-core/src/main/java/org/apache/geode/internal/cache/DistTXStateOnCoordinator.java 3) log4j geode-core/src/main/resources/log4j2-cli.xml geode-core/src/main/resources/log4j2.xml geode-core/src/main/resources/org/apache/geode/internal/logging/log4j/log4j2-legacy.xml 4) config geode-core/src/main/resources/META-INF/schemas/schema.pivotal.io/gemfire/cache/cache-8.1.xsd geode-core/src/main/resources/org/apache/geode/admin/doc-files/*.dtd // are these important? geode-site/content/schema/cache/cache-1.0.xsd 5) tests geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt **/cachejta.xml geode-core/src/test/resources/org/apache/geode/security/templates/*.dtd geode-core/src/test/resources/org/apache/geode/internal/logging/log4j/custom/log4j2-custom.xml geode-core/src/test/resources/org/apache/geode/test/golden/log4j2-test.xml geode-core/src/test/resources/org/apache/geode/test/golden/log4j2-test.xml 6) weird stuff geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsJUnitTest.java uses an internal hostname? Anthony > On Sep 14, 2016, at 7:10 PM, Hitesh Khamesra <hitesh...@yahoo.com.INVALID> > wrote: > > Yes, all changes are in "feature/GEODE-37_2" branch. Please let me know if > you see any issue with it. > I need to merge one chenkin which happen in-between. > One can look history in following way.. > git log --follow > ./geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java > > Thanks.Hitesh > > > From: Anthony Baker <aba...@pivotal.io> > To: dev@geode.incubator.apache.org > Sent: Wednesday, September 14, 2016 7:02 PM > Subject: Re: GEODE-37 (Hold your checkins in develop) > > Thanks Hitesh! Are your changes available on a feature branch where we could > review and comment? > > Anthony > >> On Sep 13, 2016, at 3:30 PM, Hitesh Khamesra <hitesh...@yahoo.com.INVALID> >> wrote: >> >> As part of GEODE-37, I am changing com.gemstone.gemfire package name to >> org.apache.geode. >> Thus I request you to hold your checkins in "develop" for next couple of >> days. I will update you once I am done with that. >> Thanks.HItesh >> > >
signature.asc
Description: Message signed with OpenPGP using GPGMail
