-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51810/#review149140
-----------------------------------------------------------


Ship it!




Check to make sure GEODE-17 can still be used for new checkins (I think we're 
supposed to create new tickets) and then Ship It!

- Kirk Lund


On Sept. 12, 2016, 3:28 p.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51810/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2016, 3:28 p.m.)
> 
> 
> Review request for geode, Kevin Duling, Kirk Lund, and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-17: pass the properties created by authInit to the security manager
> 
> Our GeodeSecurityUtil will always only takes a username and password, while 
> the client/peer's authInit geneates a Properties object which the 
> SecurityManager will eventually use to authenticate. This change will make 
> sure the Properties generated by the authInits will be sent intact to the 
> SecurityManager. Still in the case of gfsh/pulse/jmx login, we would send in 
> the username/password in the Properties with the key of "security-username" 
> and "security-password". So any implementation of SecurityManager needs to 
> handle these special keys.
> 
> 
> Diffs
> -----
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/auth/GMSAuthenticator.java
>  7fc212cf5af54c128644aa6a63579654b79a58e4 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/HandShake.java
>  8dfb476b4238399790d9520ae902b65bfc71c60f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java
>  5fa5564831faadce7efd338a74b09172009d1b99 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/security/IntegratedSecurityService.java
>  a6ec7fa146881c3fed20adfc45db9ebed0bbf0a1 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/security/SecurityService.java
>  dd8c69b894a3e244111dcd2425fcd9d425356a1a 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/security/shiro/CustomAuthRealm.java
>  09b8d5f4e1062546bbdd19dfe0ba6124590022a8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/security/shiro/GeodeAuthenticationToken.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/security/shiro/JMXShiroAuthenticator.java
>  fe895d4b4ef2f95aee774f1b191831423fd72037 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/support/LoginHandlerInterceptor.java
>  c831d0a99f99a12e8af29716e7a4c3ee4c75069f 
>   
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/auth/GMSAuthenticatorWithSecurityManagerTest.java
>  b00b3ff01ae5c718f45ced6ce2106705ad24f12e 
>   
> geode-core/src/test/java/com/gemstone/gemfire/security/IntegratedClientAuthDUnitTest.java
>  0f53cbc220c61158c992938d4ea108c24d7a9969 
> 
> Diff: https://reviews.apache.org/r/51810/diff/
> 
> 
> Testing
> -------
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Reply via email to