> On Sept. 8, 2016, 8:49 p.m., Anthony Baker wrote: > > -1 Need to update LICENSE files (both in root and in geode-assembly) with > > version changes. Can you also describe how the library updates are needed > > for the security work? I couldn't make that connection from the JIRA. > > Jinmei Liao wrote: > We are spring security to secure developer rest, so while doing that, we > thought it would be a good idea to use the latest, and while upgrading spring > security, we also need to upgrade the dependant libraries, which include > springframework and so on and on.... > > Anthony Baker wrote: > I should have mentioned NOTICE files as well. There are several those so > use: `find . -name "NOTICE"`.
Please follow-up with Anthony before committing. See what or when his -1 would change to +1. He may want to generate one more Geode RC before opening up changes in dependencies that ship in the release. It should be ok to update dependencies that do NOT ship in the release (such as junit, mockito, etc). - Kirk ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51728/#review148254 ----------------------------------------------------------- On Sept. 8, 2016, 3:45 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51728/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2016, 3:45 p.m.) > > > Review request for geode, Kevin Duling, Kirk Lund, Udo Kohlmeyer, and Dan > Smith. > > > Repository: geode > > > Description > ------- > > * updated the spring framework libraries > * updated the spring security libraries and related upgrades > * fixed the tests and uitests > > > Diffs > ----- > > > geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/RestInterfaceJUnitTest.java > 8246671a7e70267d64e354ad3ce43c1afb56f7c3 > > geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/RestSecurityDUnitTest.java > 847ca7675da6c0490e0fdc9ceacda89c4a1ec7e8 > geode-assembly/src/test/resources/expected_jars.txt > 939464a92a3f1846b8fb9b9d1faa75dad5133289 > geode-core/build.gradle ea1fce20f45b523e98b62b7569275c0079313a5a > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/shell/GfshInitFileJUnitTest.java > 529336f813cfd6a0f2b227281084a805f34c1729 > geode-pulse/build.gradle e53a698700f0de62088b3ac50cb96d4841315124 > > geode-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/security/GemFireAuthentication.java > 391ad39d22dfe37ee056c7cdeb6d2bf6554206ae > > geode-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/security/GemFireAuthenticationProvider.java > 2d7d6068337e95a3bcc6acc1aa211bf8c6da19d1 > > geode-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/service/MemberGatewayHubService.java > dd84b75c5742b3457d82a1a101521948cc8508f2 > geode-pulse/src/main/webapp/Login.html > f22490f4df098c0b12dadeefcb1855a51efc6281 > geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml > 60edb18ba615b69e6fc04fde35bf829dcfef34db > geode-pulse/src/main/webapp/WEB-INF/spring-security.xml > b14d03d2a27f061c37af8a644610156fc4b651a9 > > geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAuthTest.java > 65cd47fb111e765cc515466728221ef6607221ca > > geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAutomatedTest.java > 299a343bd7258c97a5ce8b63ae5e5e35ae242142 > > geode-web-api/src/main/java/com/gemstone/gemfire/rest/internal/web/util/JSONUtils.java > cb9b39df46701903a1c5c0bf78d7e728083a27a3 > > geode-web-api/src/main/java/com/gemstone/gemfire/rest/internal/web/util/JsonWriter.java > a0ff676a9eeb64cf1c8151a60a20633a38ef80f1 > geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml > e96acb0d2805abce804b04be678374054652f671 > geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml > ce659336c0cad8ce8e75de50ee69856259c69af2 > gradle/dependency-resolution.gradle > 91d1755848ba9ce23fab3190555c2906bcffd97b > gradle/dependency-versions.properties > a19520cb6f75bd63136d99ff62efd2b9d5f45643 > > Diff: https://reviews.apache.org/r/51728/diff/ > > > Testing > ------- > > precheckin and uitests and pulse > > > Thanks, > > Jinmei Liao > >
