> On Sept. 15, 2016, 9:27 p.m., Kirk Lund wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java, > > line 633 > > <https://reviews.apache.org/r/51925/diff/1/?file=1499054#file1499054line633> > > > > This will result in enabling security for both client/server and > > gateway when isClientSecurityRequired is true. Is that ok?
I believe this is OK. It was like that before security-enabled-components is introduced. And when user has an Authenticator or SecurityManager in place, i.e gateway needs to be secured as a client/server connection anyway. - Jinmei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51925/#review149135 ----------------------------------------------------------- On Sept. 15, 2016, 6:19 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51925/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2016, 6:19 p.m.) > > > Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > * revert this if we want to pull this back in. > > We decided to use an all or nothing approach for security. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/cache/client/internal/ConnectionFactoryImpl.java > b6460ebc35d0a7e8f2bfb6838249d1f6153d92d6 > > geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java > d843792168e91b39b686c84de66b0087c1ae65b4 > > geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java > 727c5ab504aadb950b5f765a7201e0704107f9bc > > geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfig.java > 692c2b9aa4269cc332b8a833af80b69cfd8404e4 > > geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfigImpl.java > 5a3ec274f1209d6c71c923e74b60c1f2edea0aaf > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java > 68ec0c0041f204775541db396022a1df14c868fe > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitor.java > 5717c30c8234452857a0226207663d13b72e7dd3 > > geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java > 495a85b8403be543f619b4d3cf88b5100d1ef159 > > geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java > bd6a8f8a428ff30cc532788f6f57ed37585f06a9 > geode-core/src/main/java/org/apache/geode/internal/admin/SSLConfig.java > 4b96d5519f0b75fff3937f04e8cb2404859c3970 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java > 5bddfa5a9b2afc7f1746bad69eee3048c7f32c9e > geode-core/src/main/java/org/apache/geode/internal/net/SocketCreator.java > c6ad9ce3000842f7d6b4a34389d02123e0249af3 > > geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java > 2ed46465e12633b794458c9de6630ae037a631d1 > > geode-core/src/main/java/org/apache/geode/internal/security/SecurableComponent.java > 1eac87c80ad2c64021362311c5d369c198af209a > > geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java > 7380c9a0cb7382f8a2758acc1018fd793ce815df > geode-core/src/main/java/org/apache/geode/internal/tcp/TCPConduit.java > 3cdfa5a82ad23df5b6f0992ad0781bd71dd248fd > geode-core/src/main/java/org/apache/geode/management/GemFireProperties.java > 592bfdd982e15d3a5379dc3648d984b28ea8cf7b > > geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java > ad4b3b746ce7e3ea40f4ccfcd6b103e37eb1f16c > geode-core/src/main/java/org/apache/geode/security/SecurableComponents.java > beb560086f164ea8a02bdc3e379eace3f44ff599 > > geode-core/src/test/java/org/apache/geode/cache/client/internal/CacheServerSSLConnectionDUnitTest.java > e1ee4b104b111702d551078e7e145e95349dc498 > > geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherRemoteIntegrationTest.java > 2aa0c7d74831bcbcfbe5e87bfc75b9710d9553fa > > geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTest.java > 98ee86f0bb69e8e655e5fa4860413d44b5465149 > > geode-core/src/test/java/org/apache/geode/distributed/internal/AbstractDistributionConfigTest.java > 293cbd2d6e0c10fac32175d324cb7048cd9057b5 > > geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java > 978a0d021c6efb055fc4a3233e9150781ce54b7a > > geode-core/src/test/java/org/apache/geode/internal/security/IntegratedSecurityServiceTest.java > 333875edd3af22c8b39c4e1f2363cf90f4a1c754 > > geode-core/src/test/java/org/apache/geode/internal/security/SecurityConfigIntegrationTest.java > aab934e6521e6a203ca839950afe4cf0b53737e7 > > geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java > 1bf1056ccff1f1d2e9f254102545fe82fd18b1a2 > geode-core/src/test/java/org/apache/geode/management/JMXMBeanDUnitTest.java > 05c9022e36e50261a2c83548d092b9b46b8f23ff > > geode-core/src/test/java/org/apache/geode/security/IntegratedSecurityCacheLifecycleDistributedTest.java > 494c4d46cdce885a39e618bdac2f9a874e530194 > > geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt > b3bab0f4d9e6d86d5c86506c6d4893f444f32e27 > > Diff: https://reviews.apache.org/r/51925/diff/ > > > Testing > ------- > > precheckin running > > > Thanks, > > Jinmei Liao > >
